Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add built-in titles for the activityBar items #424

Merged
merged 3 commits into from
Sep 15, 2021
Merged

Conversation

wewoor
Copy link
Collaborator

@wewoor wewoor commented Sep 14, 2021

Description

补充默认的 Activity Bar Title 数据

Changes

  • 补充 Explorer , Account, Search, Settings 的标题
  • 补充 Account 本地化数据

@wewoor wewoor self-assigned this Sep 14, 2021
@wewoor wewoor requested a review from mortalYoung September 14, 2021 03:11
@wewoor wewoor added the bug Something isn't working label Sep 14, 2021
@wewoor wewoor added this to the 0.9.0-beta.1 milestone Sep 14, 2021
@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #424 (7de109b) into main (366a635) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   81.06%   81.06%   -0.01%     
==========================================
  Files         177      177              
  Lines        4875     4874       -1     
  Branches     1051     1050       -1     
==========================================
- Hits         3952     3951       -1     
  Misses        914      914              
  Partials        9        9              
Impacted Files Coverage Δ
src/model/workbench/activityBar.ts 100.00% <ø> (ø)
src/model/workbench/explorer/explorer.tsx 92.30% <ø> (ø)
src/model/workbench/search.tsx 100.00% <ø> (ø)
src/workbench/workbench.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 366a635...7de109b. Read the comment docs.

Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 0a5c31d into main Sep 15, 2021
@wewoor wewoor deleted the fix/activityBar branch September 15, 2021 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants