Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can't add the new panel when open it #390

Merged
merged 2 commits into from
Sep 2, 2021
Merged

fix: can't add the new panel when open it #390

merged 2 commits into from
Sep 2, 2021

Conversation

wewoor
Copy link
Collaborator

@wewoor wewoor commented Sep 2, 2021

Overview

使用 PanelService.open 方法,可以直接添加不存在的面板对象

Fixes #388

Changes

  • 调用 open 时,如果是不存在的 Panel 项,执行 add 操作,在设置为 current

How Has This Been Tested?

  • 已补充 open 单元测试用例

@wewoor wewoor requested a review from mortalYoung September 2, 2021 03:23
@wewoor wewoor self-assigned this Sep 2, 2021
@wewoor wewoor added the bug Something isn't working label Sep 2, 2021
@wewoor wewoor added this to the 0.9.0-alpha.5 milestone Sep 2, 2021
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #390 (611a673) into main (6bb6605) will increase coverage by 1.81%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
+ Coverage   73.35%   75.17%   +1.81%     
==========================================
  Files         176      176              
  Lines        4797     4806       +9     
  Branches     1033     1036       +3     
==========================================
+ Hits         3519     3613      +94     
+ Misses       1270     1185      -85     
  Partials        8        8              
Impacted Files Coverage Δ
src/services/workbench/panelService.ts 98.76% <100.00%> (+0.03%) ⬆️
test/utils.ts 100.00% <0.00%> (ø)
src/services/helper.ts 100.00% <0.00%> (ø)
src/workbench/menuBar/menuBar.tsx 87.50% <0.00%> (ø)
...c/services/workbench/explorer/editorTreeService.ts 100.00% <0.00%> (ø)
...c/services/workbench/explorer/folderTreeService.ts 96.49% <0.00%> (+80.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bb6605...611a673. Read the comment docs.

Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit f8eddab into main Sep 2, 2021
@wewoor wewoor deleted the fix/panel branch September 2, 2021 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The molecule.panel.open method can't add a new panel
2 participants