Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support set the order of the panel #351

Merged
merged 1 commit into from
Aug 21, 2021
Merged

feat: support set the order of the panel #351

merged 1 commit into from
Aug 21, 2021

Conversation

wewoor
Copy link
Collaborator

@wewoor wewoor commented Aug 20, 2021

Overview

Support set the order of the PaneItem when adding a new one

Changes

  • Add the sortIndex property for the PanelItem model
  • Add the default sortIndex value for the OutputPanel and ProblemsPanel

@wewoor wewoor requested a review from mortalYoung August 20, 2021 09:15
@wewoor wewoor self-assigned this Aug 20, 2021
@wewoor wewoor added the enhancement New feature or request label Aug 20, 2021
@wewoor wewoor added this to the 0.9.0-alpha.5 milestone Aug 20, 2021
@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #351 (769345c) into main (20ee544) will increase coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   56.98%   56.99%   +0.01%     
==========================================
  Files         173      173              
  Lines        4640     4644       +4     
  Branches     1023     1024       +1     
==========================================
+ Hits         2644     2647       +3     
- Misses       1973     1974       +1     
  Partials       23       23              
Impacted Files Coverage Δ
src/model/problems.tsx 100.00% <ø> (ø)
src/model/workbench/panel.tsx 100.00% <ø> (ø)
src/workbench/panel/panel.tsx 84.21% <75.00%> (-2.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20ee544...769345c. Read the comment docs.

Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 95470fe into main Aug 21, 2021
@wewoor wewoor deleted the feat/sortPanel branch August 21, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants