Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add an if statement before calling the unmountComponentAtNode #319

Merged
merged 1 commit into from
Aug 10, 2021
Merged

fix: add an if statement before calling the unmountComponentAtNode #319

merged 1 commit into from
Aug 10, 2021

Conversation

wewoor
Copy link
Collaborator

@wewoor wewoor commented Aug 10, 2021

简介

执行 unmountComponentAtNode 方法时，添加 if 声明

主要变更

  • 添加 if 条件判断 contentContainer 是否存在，不存在的情况下，执行 unmountComponentAtNode 会导致 React 异常，页面白屏

@wewoor wewoor requested a review from mortalYoung August 10, 2021 05:44
@wewoor wewoor added the bug Something isn't working label Aug 10, 2021
@wewoor wewoor added this to the 0.9.0-alpha.5 milestone Aug 10, 2021
mortalYoung
mortalYoung approved these changes Aug 10, 2021
View reviewed changes
Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 99a7d81 into main Aug 10, 2021
@wewoor wewoor deleted the fix/contextView branch August 10, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortalYoung mortalYoung mortalYoung approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.9.0-alpha.5
Development

Successfully merging this pull request may close these issues.
2 participants
@wewoor @mortalYoung