Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setting config not working when deleting property #309

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 修复删除内置设置的时候,该值不会还原成默认值的问题

主要变更

  • 当获取到 setting 中的值后,再和 init 的值做一次 assign

Related Issues

Closed #280

@wewoor wewoor requested a review from ProfBramble August 5, 2021 11:17
@wewoor wewoor merged commit 23116af into main Aug 5, 2021
@wewoor wewoor deleted the fix/setting branch August 5, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't recover the built-in Settings configuration after remove it from the settings.json
2 participants