refactor: update the MenuBarService #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfBramble
pushed a commit
that referenced
this pull request
Aug 4, 2021
* refactor: remove addRootMenu method, and rename initMenu to initMenus * docs: add comments for the IMenuBarService interface
ProfBramble
pushed a commit
that referenced
this pull request
Aug 5, 2021
* refactor: remove addRootMenu method, and rename initMenu to initMenus * docs: add comments for the IMenuBarService interface
mumiao
pushed a commit
that referenced
this pull request
Aug 5, 2021
…eys (#298) * feat: menu bar add new file function * feat: add encapsulated event state automata * feat: add menu bar action to menu bar controller * feat: define menu function and export operation id * feat: register view shortcut * feat: add key code string constant * feat: register the view method in the editor service * feat: register select all keyboard listener class * feat: register copy line up keyboard listener class * refactor: register undo and redo to keybinding * perf: extract function to keybinding * feat: add new file to keybinding * feat: use monaco service to get menu functions * feat: register menubar onSelect to subscribers * refactor: update the MenuBarService (#292) * refactor: remove addRootMenu method, and rename initMenu to initMenus * docs: add comments for the IMenuBarService interface * perf: move create file or folder function in service * feat: add new file to keybinding * feat: register menubar onSelect to subscribers * fix: increase call rigor * feat: add story of open any file on disk * feat: support file highlighting * feat: register the view method in the editor service * perf: extract function to keybinding * feat: add new file to keybinding * perf: better type description Co-authored-by: Ziv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
initMenutoinitMenus