Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve unreasonable design #232

Merged
merged 1 commit into from
Jul 13, 2021
Merged

fix: improve unreasonable design #232

merged 1 commit into from
Jul 13, 2021

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 修复在开发 ScheduleX 的时候遇到的一些不合理的地方

主要变更

  • menu 支持 [key:string]: any 拓展属性
  • editor group 的 actions 支持通过 updateGroupActions 方法扩展新的属性
  • 支持通过 onActionsClick 事件监听到 editor group 的 actions 的点击事件
  • folderTree 的 newFile 由于在 ScheduleX 中需要重写交互，所以考虑把新建文件的操作从内置的 extensions 中移除了。并且由于 newFile; newFolder; newRootFolder; 三者具有相似性，所以把这三者全部从内置的 extensions 中移除，让用户自行实现

@wewoor wewoor self-requested a review July 12, 2021 09:17
@wewoor wewoor merged commit 74f8976 into main Jul 13, 2021
@wewoor wewoor deleted the fix/editor branch July 13, 2021 02:10
@mortalYoung mortalYoung mentioned this pull request Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wewoor wewoor wewoor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mortalYoung @wewoor