fix: improve global contextMenu in activity bar #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wewoor
reviewed
Jun 24, 2021
mumiao
reviewed
Jun 27, 2021
| @@ -122,8 +125,10 @@ export function getPositionByPlacement( | |||
| y = domRect.y + domRect.height; | |||
| } else if (placement === 'left') { | |||
| x = domRect.x - domRect.width; | |||
| } else if (placement === 'rightBottom') { | |||
There was a problem hiding this comment.
Suggested change
| } else if (placement === 'rightBottom') { | |
| } else if (placement === 'bottomRight') { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
简介
DropDown组件来唤醒，会去计算位置，由于点击唤起菜单和右键点击唤起菜单不同，所以这里选择也用DropDown的方式主要变更
activityBarItem中的点击事件DropDown中的 placement 的类型，新增rightBottom表示支持居右并底部对齐