fix(collapse): improve the timing to detect panel content whether empty #184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
简介
render
的时候实时去计算每一个 panel 是否是空内容,然后再去计算位置。这就会导致无法准确的判断 panel 是否为空内容,因为有可能 collapse panel 是有 HOC 的。因此,考虑修改判断 content 是否为空的逻辑。主要变更
render
的时候判断,移到useLayoutEffect
里面延迟判断。elm.style.height
的方式改变位置。为了准确找到对应的 dom 结构,通过data-*
使得可以准确找到对应 panel 的位置。