Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: appearance needs re layout after show or hide #171

Merged
merged 1 commit into from
Jun 9, 2021
Merged

feat: appearance needs re layout after show or hide #171

merged 1 commit into from
Jun 9, 2021

Conversation

mumiao
Copy link
Collaborator

@mumiao mumiao commented Jun 7, 2021 •
edited
Loading

Description

  1. activityBar 跟menuBar 本身就是flex弹性布局，之前是因为定位了，所以Appearance隐藏/显示后没有触发重绘
    Resolved Appearance needs re layout after show or hide #97
  2. LayoutService涉及一些全局的设计变动，另开PR完成

@mumiao mumiao requested a review from wewoor June 7, 2021 13:47
@mumiao mumiao self-assigned this Jun 7, 2021
@mumiao mumiao added the enhancement New feature or request label Jun 7, 2021
@mumiao mumiao added this to the 0.9.0-alpha.3 milestone Jun 7, 2021
@wewoor
Copy link
Collaborator

wewoor commented Jun 9, 2021

@mumiao 看代码，好像少了对 statusBar 的处理

@mumiao
Copy link
Collaborator Author

mumiao commented Jun 9, 2021

statusBar

statusBar 走的定位 不会占据空间 我测试过ok

@wewoor wewoor merged commit a809494 into main Jun 9, 2021
@wewoor wewoor deleted the refactor_layout branch June 9, 2021 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wewoor wewoor Awaiting requested review from wewoor

Assignees

@mumiao mumiao

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.9.0-alpha.3
Development

Successfully merging this pull request may close these issues.

Appearance needs re layout after show or hide
2 participants
@mumiao @wewoor