-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: show text along with codespace numbers #1740
Comments
Thanks for the feature request! |
i think that's what Sei did (but im not 100% sure), they used the CLI to interpret the error msgs, instead of adding them directly to the chain. i could not agree more with @alpe solution of adding it to the CLI instead of anywhere else |
CLI helps, but in case of IBC, this wont help. Like errors are passed through ACK message. |
There are two related topics here and we need to address them separately: Errors in submessage repliesCurrently redacted due to consensus problems. This will change for all errors coming from CosmWasm contracts with 2.0. The change is already implemented here and will be integrated into wasmd soon. Errors in acknowledgements
func NewErrorAcknowledgement(err error) Acknowledgement {
// the ABCI code is included in the abcitypes.ResponseDeliverTx hash
// constructed in Tendermint and is therefore deterministic
_, code, _ := errorsmod.ABCIInfo(err, false) // discard non-determinstic codespace and log values
return Acknowledgement{
Response: &Acknowledgement_Error{
Error: fmt.Sprintf("ABCI code: %d: %s", code, ackErrorString),
},
}
} This is because codespace is not part of consesus for some reason. I think a wasmd port of |
amazing!, good to know this is being worked on. for new comers (devs with experience in other fields) and general new devs that are starting directly in blockchain and in cosmwasm it can be a bit frustrating and challenging to figure out what broke with the current errors. i believe this change can help improve dev UX by a lot and be more welcoming to devs without tons of experience thank you Simon cheers! |
Just catching up. So this is fixed in ibc-go v8.3.0? Seems to be so: cosmos/ibc-go#5736 (comment) |
#1911 will bring the codespace to error acks. I will keep this ticket open until we have full error texts in error acks. |
afaik sei chain does this, but many Cosmos chains doesnt. Ngl, would save a lot of time for devs.
It's quite tedious figuring out all the time what these codespace errors mean:
https://github.com/CosmWasm/wasmd/blob/7ea00e2ea858ed599141e322bd68171998a3259a/x/wasm/types/errors.go
The text was updated successfully, but these errors were encountered: