Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Left shift only implemented for Uint256 #1712

Closed
chipshort opened this issue Jun 6, 2023 · 1 comment
Closed

Left shift only implemented for Uint256 #1712

chipshort opened this issue Jun 6, 2023 · 1 comment
Milestone
1.2.7

Comments

@chipshort
Copy link
Collaborator

All the Uint*s have right shift implemented, but only Uint256 has an impl for Shl<u32>, Shl<&u32> and a checked_shl.
We should standardize this between the types.

Also note that ShlAssign is missing even for Uint256 (while ShrAssign exists for all of them)
@webmaster128 webmaster128 added this to the 1.2.7 milestone Jun 13, 2023
@chipshort chipshort mentioned this issue Jun 14, 2023
Merged
@chipshort
Copy link
Collaborator Author

Done in #1723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.7
Development

No branches or pull requests
2 participants
@webmaster128 @chipshort