Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable publish blobs after block by default #8868

Merged

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Dec 2, 2024

I've been monitoring on holesky nodes with this enabled and seems not affect much on our high-upload-bandwidth nodes.
It should be worthy for low upload-bandwidth nodes, like home stakers building blocks locally.

Wait average wait time
disabled 18.04 ms
enabled 23.48 ms

over last 2000 blocks produced on holesky

it doesn't go lower than a certain delay because we anyway spend time in blobs preparation while block publishing is already started. So we additionally wait (when enabled) only when the "time-to-first-peer-published-block" is higher.

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@mehdi-aouadi
Copy link
Contributor

So is this to prioritise block publishing for low bandwidth nodes (when block and blobs publishing are done simultaneously, blobs could delay the block publishing by consuming bandwidth)?

@tbenr
Copy link
Contributor Author

tbenr commented Dec 2, 2024

yes, this is essentially to wait initiating blobs publishing until we successfully published the block to at least one peer

Copy link
Contributor

@mehdi-aouadi mehdi-aouadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Makes sense since it doesn't badly affect high bandwidth node and helps the low bandwidth ones

@tbenr tbenr enabled auto-merge (squash) December 2, 2024 15:32
@tbenr tbenr merged commit 5aa4bd8 into Consensys:master Dec 2, 2024
17 checks passed
@tbenr tbenr deleted the enable-publish-blob-afte-block-by-default branch December 2, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants