add get aggregate attestation request #8483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request introduces the GetAggregateAttestationV2 API to handle Electra attestations, deprecating the old createAggregate method.
ValidatorApiHandler.java: AddedcreateAggregateV2method; deprecatedcreateAggregate.GetAggregateAttestation.java: Updated to useGetAggregateAttestationV2API; renamed response type.ValidatorApiChannel.java: IntroducedcreateAggregateV2method.MetricRecordingValidatorApiChannel.java: AddedcreateAggregateV2method; deprecatedcreateAggregate.GetAggregateAttestationRequestTest.java: Added integration tests forGetAggregateAttestationRequest.getAggregateAttestationELECTRA.json: Added sample JSON response for Electra version.getAggregateAttestationPHASE0.json: Added sample JSON response for phase0 version.FailoverValidatorApiHandler.java: AddedcreateAggregateV2method; deprecatedcreateAggregate.RemoteValidatorApiHandler.java: AddedcreateAggregateV2method; deprecatedcreateAggregate.ValidatorApiMethod.java: AddedGET_AGGREGATE_V2endpoint.SentryValidatorApiChannel.java: AddedcreateAggregateV2method; deprecatedcreateAggregate.OkHttpValidatorTypeDefClient.java: AddedcreateAggregatemethod usingGetAggregateAttestationRequest.GetAggregateAttestationRequest.java: Added new class to handleGetAggregateAttestationV2API.
13 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
tbenr
reviewed
Jul 30, 2024
validator/api/src/main/java/tech/pegasys/teku/validator/api/ValidatorApiChannel.java
Outdated
Show resolved
Hide resolved
mehdi-aouadi
force-pushed
the
8420-handler
branch
from
398f6b4 to
b86dcaf
Compare
tbenr
reviewed
Aug 1, 2024
...java/tech/pegasys/teku/validator/remote/typedef/handlers/GetAggregateAttestationRequest.java
Outdated
Show resolved
Hide resolved
tbenr
reviewed
Aug 1, 2024
.../resources/responses/get_aggregate_attestation_responses/getAggregateAttestationELECTRA.json
Outdated
Show resolved
Hide resolved
mehdi-aouadi
force-pushed
the
8420-handler
branch
from
b5a758b to
26af271
Compare
mehdi-aouadi
force-pushed
the
8420-handler
branch
from
b8ec4ff to
e0ae844
Compare
mehdi-aouadi
force-pushed
the
8420-handler
branch
from
e0ae844 to
74c5afb
Compare
mehdi-aouadi
force-pushed
the
8420-handler
branch
from
74c5afb to
184eae7
Compare
rolfyone
reviewed
Aug 21, 2024
...a/tech/pegasys/teku/validator/remote/typedef/handlers/CreateAggregateAttestationRequest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add the
GetAggregateAttestationRequest to use the newGetAggregateAttestationV2APIFixed Issue(s)
#8420
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog