You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The prover is not properly handling error cases returned when go-corset fails in trace expansion.
Impact
I don't believe any users are affected at this time.
Describe the bug
In the file prover/zkevm/arithmetization/files.go, we have this sequence:
expTraces, errs:=schema.NewTraceBuilder(sch).Build(rawTraces)
iflen(errs) >0 {
logrus.Warnf("corset expansion gave the following errors: %v", errors.Join(errs...).Error())
}
returnexpTraces, nil
The problem is that, when len(errs) > 0 we have (or can have) expTraces == nil. This arises when go-corset believes it is unable to continue with trace expansion (typically because there is some column missing from the trace).
Steps to Reproduce
To reproduce this bug you need a constraint file which is missing one or more columns required by the constraints.
Actual result
The prover will panic
Expected result
The prover should fail gracefully.
The text was updated successfully, but these errors were encountered:
The prover is not properly handling error cases returned when
go-corset
fails in trace expansion.Impact
I don't believe any users are affected at this time.
Describe the bug
In the file
prover/zkevm/arithmetization/files.go
, we have this sequence:The problem is that, when
len(errs) > 0
we have (or can have)expTraces == nil
. This arises whengo-corset
believes it is unable to continue with trace expansion (typically because there is some column missing from the trace).Steps to Reproduce
To reproduce this bug you need a constraint file which is missing one or more columns required by the constraints.
Actual result
The prover will
panic
Expected result
The prover should fail gracefully.
The text was updated successfully, but these errors were encountered: