Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container App secret settings #964

Open
isaacabraham opened this issue Aug 5, 2022 · 2 comments
Open

Container App secret settings #964

isaacabraham opened this issue Aug 5, 2022 · 2 comments

Comments

@isaacabraham
Copy link
Member

At the moment, container apps has a multitude of ways to apply settings. The thing that you can't currently (easily) do in Farmer is have a secret setting and have it applied into the container app - it doesn't get set properly. @ninjarobot I remember we spoke about this - I'd like to submit a PR that fixes this but it might be a breaking change in terms of the API (but not in terms of ARM generation as such). The currently codebase is IIRC (I need to dig up a prototype fix I made) broken.
@ninjarobot
Copy link
Collaborator

Those are difficult to get working and an improvement will be welcome. What would the breaking change be?

@martinbryant
Copy link
Contributor

@isaacabraham any news on a possible PR for this? Happy to take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ninjarobot @isaacabraham @martinbryant