Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coolwsd.xml defaults do not match built-in defaults #10049

Closed
xzfc opened this issue Sep 14, 2024 · 1 comment · Fixed by #10129
Closed

coolwsd.xml defaults do not match built-in defaults #10049

xzfc opened this issue Sep 14, 2024 · 1 comment · Fixed by #10129
Assignees
Labels
bug Something isn't working

Comments

@xzfc
Copy link

xzfc commented Sep 14, 2024

Describe the Bug

The comment in COOLWSD.cpp states that defaults from coolwsd.xml and built-in defaults from the coolwsd C++ sources should be the same. However, they are not. Consequently, when coolwsd is started with an empty coolwsd.xml, the factual configuration would not be the same as if it was started with the default coolwsd.xml.

This cause problems for systems that generate the coolwsd.xml config file on its own (e.g. Nix). We can't generate coolwsd.xml from scratch with just a few user-specified options, we have to patch the default coolwsd.xml instead. This is inconvenient.

Incomplete list of mismatched options:

Option coolwsd.xml built-in
logging.level @COOLWSD_LOGLEVEL@/warning trace
num_prespawn_children 4 1
per_document.cleanup[@enable] true false
per_view.out_of_focus_timeout_secs 300 120 or 60
ssl.termination false true
ssl.cert_file_path /etc/coolwsd/cert.pem COOLWSD_CONFIGDIR "/cert.pem"/
/usr/local/etc/coolwsd/cert.pem
storage.ssl.as_scheme true false
And others

Steps to Reproduce

  1. Create empty.xml with this contents: <config></config>.
  2. First run: run coolwsd with the default coolwsd.xml.
  3. Second run: run coolwsd --config-file=empty.xml.

Expected Behavior

Both runs should behave exactly the same.

Actual Behavior

They are not. Presumably, the most visible difference is the logging level (see the table above) and paths to SSL certs.

@xzfc xzfc added bug Something isn't working unconfirmed labels Sep 14, 2024
@timar timar removed the unconfirmed label Sep 25, 2024
@timar timar self-assigned this Sep 25, 2024
@timar
Copy link
Member

timar commented Sep 25, 2024

wrt. storage.ssl.as_scheme there is a comment why it is so: wsd/wopi/StorageConnectionManager.cpp#L163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants