-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some margin in header and paypall button #12
Conversation
@davidchambers ups... what happened there... hm.... will have a look |
@davidchambers when do you get that? I cant reproduce. |
@davidchambers ah, in Chrome :O |
It's frustrating when things render differently in different browsers. 😠 This line seems to be the problem: #paypal-button {
float: right;
} If I disable this rule the problem goes away. I can't explain this, but CSS is often inexplicable. 😝 |
Ah, interesting. How can we stick it to the right without float then? |
@davidchambers Should be alright now. Could you check? 😊 |
I'd like to, but I'm having trouble getting the site running. $ bundle install
-bash: bundle: command not found 👎 $ gem install bundler
Fetching: bundler-1.13.1.gem (100%)
Successfully installed bundler-1.13.1
Parsing documentation for bundler-1.13.1
Installing ri documentation for bundler-1.13.1
Done installing documentation for bundler after 6 seconds
1 gem installed 👍 $ bundle install
...
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
...
An error occurred while installing nokogiri (1.6.8), and Bundler cannot continue.
Make sure that `gem install nokogiri -v '1.6.8'` succeeds before bundling. 👎 $ gem install nokogiri -v '1.6.8'
Building native extensions. This could take a while...
...
To see why this extension failed to compile, please check the mkmf.log which can be found here:
/Users/dc/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/extensions/x86_64-darwin-15/2.3.0-static/nokogiri-1.6.8/mkmf.log
extconf failed, exit code 1 👎 Ruby, why must our relationship be this way? 😢 |
With @Malwine's help I got the site running. I did three things:
I'm not sure whether step 1 was necessary, but it certainly didn't hurt. :) For the record I'm running OS X 10.11.6, MacPorts 2.3.4, and rbenv 0.3.0-362-g0c7224a. |
The fix you made is working for me, @Malwine. :) I noticed one more thing: the border is missing. This change should fix it: --- a/css/main.css
+++ b/css/main.css
@@ -150,7 +150,7 @@ img {
border-radius: 6px;
font-size: 13px;
background: #fec348 none repeat scroll 0 0;
- border-color: #feb215;
+ border: 1px solid #feb215;
color: #002f86;
} |
Thanks @davidchambers you are the pro for github markdown formatting man 😅 |
🌳 |
Fixes #11
and
fixes some spacing in the header
and
fixes #10