-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect current video resolutions when replacing the video file #6662
Comments
And to add a precision : If it's usefull, in H5P, I'm setting as the source the download url of the web-video file, for example : I hope I'm clear :-) |
Hi,
It would break cache invalidation. I suggest to create a dedicated issue to discuss about an endpoint that can redirect to the latest video file URL |
Hi Chocobozzz, I must confess that I don't know what "cache invalidation" is, so I don't know what to write in this other dedicated issue. |
We change the name of the video file every time we update it (after a new transcoding job for example) so clients don't get the previous file when reverse proxy in front of PeerTube or CDNs caches static files. I created the issue: #6701 |
Thanks you for the explanation, and for creating the issue. |
Describe the current behavior
Hi,
When Peertube is set to do only HLS transcoding by default, we can still manually trigger a web-video transcoding too.
(I use it on some video when we need to embed the stream in H5P interactiv object, which doesn't support well HLS stream).
But when I replace the video by a new version, all HLS resolution are transcoded as expected, but all pre-existing web-video resolutions are deleted (leaving the H5P interactive object with missing stream error).
BEFORE I upload a new version (with manually triggered web-video resolutions) :
AFTER I've uploaded a new version (new HLS version, but all web-video have been deleted) :
Steps to reproduce
1.set Peertube to do only HLS resolutions
2.upload a video
3.manually trigger webtorrent transcoding of the video
4.upload a new version of the video
5.see that all web-video resolutions have been deleted
Describe the expected behavior
On an Peertube server with only one type of transcoding activated by default, I expect to see the "upload new version" process to check if any alternative transcoding (HLS or Web-video) already existed at the time of the replacement, and if so, it triggers the same transcoding.
So in my case, only HLS is set by default. But if Peertube "see" that web-video already existed for a video, it will trigger also this web-video transcoding during this replacement, in addition to the default HLS.
Additional information
PeerTube instance:
Browser name, version and platforms on which you could reproduce the bug:
Link to browser console log if relevant:
Link to server log if relevant (
journalctl
or/var/www/peertube/storage/logs/
):The text was updated successfully, but these errors were encountered: