Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make SendBlockReqestByHash synchronous when check justification #1771

Closed
EclesioMeloJunior opened this issue Aug 26, 2021 · 1 comment
Closed

Comments

@EclesioMeloJunior
Copy link
Member

Task summary

  • The function handleNeighbourMessage at lib/grandpa/message_handler.go checks the justification and if there is some error and the error is a blocktree.ErrStartNodeNotFound error we must exec the h.grandpa.network.SendBlockReqestByHash(msg.Vote.Hash) call synchronously

Specification reference

  • N/A

Other information and links

  • N/A
@noot
Copy link
Contributor

noot commented Sep 3, 2021

going to close this for now and this won't be needed after the sync refactor, after it's done all instances of sending block requests should only be done by the sync package

@noot noot closed this as completed Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants