fix(rpc/subscription): subscribe runtime version notify when version changes #1686

edwardmack · 2021-07-08T22:40:52Z

Changes

implemented code that notifies subscribed listener when runtime version changes.

Tests

go test ./dot/rpc/subscription/... -run ^TestRuntimeChannelListener_Listen$

Issues

closes: state_subscribeRuntimeVersion does not notify when version changes #1474

codecov · 2021-07-08T23:04:05Z

Codecov Report

Merging #1686 (154061f) into development (0932ee8) will increase coverage by 0.21%.
The diff coverage is 61.85%.

@@               Coverage Diff               @@
##           development    #1686      +/-   ##
===============================================
+ Coverage        58.65%   58.87%   +0.21%     
===============================================
  Files              183      183              
  Lines            19002    19081      +79     
===============================================
+ Hits             11146    11233      +87     
+ Misses            5918     5907      -11     
- Partials          1938     1941       +3

Flag	Coverage Δ
unit-tests	`58.87% <61.85%> (+0.21%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
dot/rpc/subscription/subscription.go	`62.50% <0.00%> (-2.72%)`	⬇️
dot/rpc/subscription/websocket.go	`57.30% <0.00%> (-3.51%)`	⬇️
dot/state/block_notify.go	`73.86% <65.62%> (-2.93%)`	⬇️
dot/state/block.go	`42.67% <78.94%> (-0.19%)`	⬇️
dot/rpc/subscription/listeners.go	`73.57% <81.25%> (+8.49%)`	⬆️
dot/rpc/modules/api_mocks.go	`100.00% <100.00%> (+100.00%)`	⬆️
lib/babe/babe.go	`56.70% <0.00%> (-1.15%)`	⬇️
lib/blocktree/blocktree.go	`55.61% <0.00%> (-1.13%)`	⬇️
dot/network/service.go	`69.31% <0.00%> (+0.85%)`	⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0932ee8...154061f. Read the comment docs.

EclesioMeloJunior · 2021-07-09T19:55:29Z

dot/core/service.go

+
+	s.runtimeChangedLock.Lock()
+	s.runtimeChanged[id] = ch
+	s.runtimeChangedLock.Unlock()


why are needed these two locks? Just s.runtimeChangedLock.Lock() could not be enough?

Right, I've updated to use just one lock (and unlock with defer).

dot/core/service.go

EclesioMeloJunior · 2021-07-09T19:57:48Z

dot/core/service.go

@@ -579,3 +609,33 @@ func (s *Service) GetMetadata(bhash *common.Hash) ([]byte, error) {
 	s.rt.SetContextStorage(ts)
 	return s.rt.Metadata()
 }
+
+// RegisterRuntimeUpdatedChannel function to register chan that is notified when runtime version changes
+func (s *Service) RegisterRuntimeUpdatedChannel(ch chan<- runtime.Version) (byte, error) {


Would be nice if we have an Unregister method that closes the channel and remove it from the map

added Unregister method.

noot · 2021-07-12T17:49:54Z

dot/core/service.go

@@ -69,6 +71,9 @@ type Service struct {

 	// Keystore
 	keys *keystore.GlobalKeystore
+
+	runtimeChangedLock sync.RWMutex
+	runtimeChanged     map[byte]chan<- runtime.Version


rename runtimeUpdateSubscriptions or some thing like that?

updated to runtimeUpdateSubscriptions and runtimeUpdateSubscriptionsLock

noot · 2021-07-12T17:50:33Z

dot/core/service.go

+	ver, err := s.rt.Version()
+	if err == nil {
+		go s.notifyRuntimeUpdated(ver)
+	}


if this errors that is bad, so should handle that error

updated to return err here.

noot

mostly looks good, but will conflict with @arijitAD 's PR #1638 . you two will have to coordinate on which PR will go in first, because the second one will need to update/move things around

timwu20 · 2021-07-12T20:02:19Z

dot/core/service.go

+	for _, ch := range s.runtimeChanged {
+		go func(ch chan<- runtime.Version) {
+			select {
+			case ch <- version:


why is the channel being written to as a select case?

Good question, no reason, so I've removed the select case.

EclesioMeloJunior · 2021-07-14T20:25:38Z

dot/rpc/subscription/websocket.go

@@ -367,6 +376,19 @@ func (c *WSConn) initRuntimeVersionListener(reqID float64, _ interface{}) (Liste
 	return rvl, nil
 }

+func (c *WSConn) unsubscribeRuntimeVersionListener(reqID float64, l Listener, _ interface{}) {


You need to register this unsubscribe function to a webscoket method here ./dot/rpc/subscription/subscription.go

yes, I've added it.

noot · 2021-07-29T19:47:24Z

dot/core/service.go

+//func (s *Service) notifyRuntimeUpdated(version runtime.Version) {
+//	s.runtimeUpdateSubscriptionsLock.RLock()
+//	defer s.runtimeUpdateSubscriptionsLock.RUnlock()
+//
+//	if len(s.runtimeUpdateSubscriptions) == 0 {
+//		return
+//	}
+//
+//	logger.Debug("notifying runtime updated chans...", "chans", s.runtimeUpdateSubscriptions)
+//	var wg sync.WaitGroup
+//	wg.Add(len(s.runtimeUpdateSubscriptions))
+//	for _, ch := range s.runtimeUpdateSubscriptions {
+//		go func(ch chan<- runtime.Version) {
+//			defer wg.Done()
+//			ch <- version
+//		}(ch)
+//	}
+//	wg.Wait()
+//}


dot/state/block.go

noot

great work, just smaller comments

noot · 2021-08-06T19:08:56Z

dot/state/block.go

+	if err != nil {
+		return fmt.Errorf("failed to retrieve runtime version: %w", err)
+	}
+	bs.notifyRuntimeUpdated(newVersion)


I wonder if it's good to put this in a goroutine since it might block if some channel is full

good idea, added as goroutine.

noot

looks good :D

# [0.6.0](v0.5.0...v0.6.0) (2021-12-03) ### Bug Fixes * **babe:** Fix extrinsic format in block. ([#1530](#1530)) ([1a03b2a](1a03b2a)) * **ci:** add missing go-version matrix to fix development branch CI ([#2037](#2037)) ([6babe76](6babe76)) * **cmd/cfg:** Use Babe Lead value from toml config ([#2032](#2032)) ([06aa3e3](06aa3e3)) * cmd/gossamer: Generate random name if --name flag not set ([#1506](#1506)) ([3c05a88](3c05a88)) * confirm block import notifier is closed properly ([#1736](#1736)) ([ad2d85e](ad2d85e)) * **docs:** improve build-spec usage docs ([#1706](#1706)) ([2e164b4](2e164b4)) * **dot/core:** Add only extrinsic during chain reorg. ([#1609](#1609)) ([29413d4](29413d4)) * **dot/core:** Batch process transaction message. ([#1780](#1780)) ([0064836](0064836)) * **dot/core:** check transaction Validity.Propagate field to determine whether to propagate tx ([#1643](#1643)) ([81f23cc](81f23cc)) * **dot/core:** Fix handle transaction message test. ([#1607](#1607)) ([58b8725](58b8725)) * **dot/network, lib/grandpa:** fix handshake decoding and grandpa message handler sigabort ([#1631](#1631)) ([887f72c](887f72c)) * **dot/network, lib/grandpa:** fix node sync, improve devnet finality ([bcc7935](bcc7935)) * **dot/network:** add nil checks in connManager ([#2069](#2069)) ([7f9c042](7f9c042)) * **dot/network:** Check for size when decoding leb128. ([#1634](#1634)) ([d082b9e](d082b9e)) * **dot/network:** check if peer supports protocol ([#1617](#1617)) ([6bf66a4](6bf66a4)) * **dot/network:** decrease DHT find peers interval for gssmr nodes ([#1703](#1703)) ([08516a0](08516a0)) * **dot/network:** fix bugs in notifications protocol handlers; add metrics for inbound/outbound streams ([#2010](#2010)) ([8c2993d](8c2993d)) * **dot/network:** fix dht connection on discovery on devnet ([#2059](#2059)) ([da065b8](da065b8)) * **dot/network:** fix discovery between gossamer nodes ([#1594](#1594)) ([f4c79d3](f4c79d3)) * **dot/network:** fix justification request at head logic ([#1510](#1510)) ([98d1413](98d1413)) * **dot/network:** fix memory allocations with `sizedBufferPool` ([#1963](#1963)) ([e0b126b](e0b126b)) * **dot/network:** Fix missing digest in header ([#2092](#2092)) ([21ea85e](21ea85e)) * **dot/network:** Fix notification handshake and reuse stream. ([#1545](#1545)) ([a632dc4](a632dc4)) * **dot/network:** fix receiving notifications messages from substrate peers ([#1517](#1517)) ([fdf3c53](fdf3c53)) * **dot/network:** fix stream manager tests ([#1683](#1683)) ([e02eca4](e02eca4)) * **dot/network:** implement a handshake timeout ([#1615](#1615)) ([87c2f63](87c2f63)) * **dot/network:** Implement time based handle transaction ([#1942](#1942)) ([dd08424](dd08424)) * **dot/network:** move low reputation peer removal from network ConnManager to peer scoring logic (dot/peerstate) ([#2068](#2068)) ([ac16285](ac16285)), closes [#2039](#2039) * **dot/network:** Return on EOF error while reading stream. ([#1733](#1733)) ([f447eac](f447eac)) * **dot/network:** split stored streams and handshakeData into inbound and outbound ([#1553](#1553)) ([637050b](637050b)) * **dot/network:** update notificationsProtocol handshakeData to sync.Map ([#1492](#1492)) ([22f7269](22f7269)) * **dot/node:** Start websocket server only with `--ws` flag ([#1671](#1671)) ([6ecef3b](6ecef3b)) * **dot/state, lib/babe, lib/trie:** improve syncing between gossamer authority nodes ([#1613](#1613)) ([ca99fbf](ca99fbf)) * **dot/state, lib/grandpa:** update justification and SignedVote handling in database ([#1682](#1682)) ([bbdcd6f](bbdcd6f)) * **dot/state,dot/network:** improve memory usage when syncing ([#1491](#1491)) ([3b2ad8d](3b2ad8d)) * **dot/state:** add StorageState Lock/Unlock API for usage by babe and sync ([#1700](#1700)) ([3c22ace](3c22ace)) * **dot/state:** fix deadlock, fixes bootstrap syncing ([#1959](#1959)) ([dd80c09](dd80c09)) * **dot/state:** fix usage of trie.Snapshot ([#1489](#1489)) ([3880a40](3880a40)) * **dot/state:** track runtime per-block, fix runtime upgrades differing between forks ([#1638](#1638)) ([e133884](e133884)) * **dot/state:** update `*state.BlockState.AddBlockToBlockTree` to store block in `unfinalisedBlocksMap` ([#2006](#2006)) ([55d997f](55d997f)) * **dot/sync:** add nil header checks ([#2099](#2099)) ([a7d4be0](a7d4be0)) * **dot/sync:** fix block request and response logic ([#1907](#1907)) ([9c6283e](9c6283e)) * **dot/sync:** fix creating block response, fixes node sync between gossamer nodes ([#1572](#1572)) ([1328c80](1328c80)) * **dot/telemetry:** refactor telemetry to reduce CPU usage ([#1597](#1597)) ([bc31ac7](bc31ac7)) * **dot/types:** *types.Body to be of type []types.Extrinsic ([#1807](#1807)) ([4c09715](4c09715)) * **dot/types:** fix max value for digest ([#1687](#1687)) ([48405e7](48405e7)) * **dot:** fix `TestNewNode` ([#2070](#2070)) ([42908d0](42908d0)) * fix edit link ([#1507](#1507)) ([5089327](5089327)) * fix Kusama sync; add storageState lock in core.HandleTransactionMessage ([#1783](#1783)) ([1d688e4](1d688e4)) * **lib/babe, lib/runtime/wasmer:** fixes for v0.9.8+ runtime ([#2075](#2075)) ([2f9f80c](2f9f80c)) * **lib/babe:** add `--babe-lead` flag, update epoch handling logic ([#1895](#1895)) ([7abcce6](7abcce6)) * **lib/babe:** add pre-runtime digest before calling initialize_block ([#1581](#1581)) ([c1b26d3](c1b26d3)) * **lib/babe:** always use 2/3 of slot to produce block, re-add potentially valid txs to queue ([#1679](#1679)) ([cf93ad3](cf93ad3)) * **lib/babe:** call AddBlock in BABE synchronously ([#1585](#1585)) ([86acc43](86acc43)) * **lib/babe:** fix BABE state storing after building block ([#1536](#1536)) ([1a3dea2](1a3dea2)) * **lib/babe:** fix err log ([#1801](#1801)) ([a96f06a](a96f06a)) * **lib/babe:** fix setting first slot of network, fix loading BABE epoch params ([#1640](#1640)) ([5c3dbfe](5c3dbfe)) * **lib/babe:** fix timing for transition between epochs ([#1636](#1636)) ([57027db](57027db)) * **lib/blocktree:** fix blocktree bug ([#2060](#2060)) ([c17b53a](c17b53a)) * **lib/blocktree:** fix potential nil pointer dereference in `HighestCommonAncestor`, core `handleBlocksAsync` ([#1993](#1993)) ([f7f4463](f7f4463)) * **lib/blocktree:** fix setting leaves after blocktree pruning ([#1605](#1605)) ([58c0854](58c0854)) * **lib/blocktree:** removes the inconsistency to choose a deepest leaf ([#2094](#2094)) ([43d68e3](43d68e3)) * **lib/crypto/ed25519:** update ed25519 to use go-schnorrkel bip39 derivation ([#1488](#1488)) ([dfb95d2](dfb95d2)) * **lib/genesis:** Update missing and incorrect fields in genesis file. ([#1681](#1681)) ([8207704](8207704)) * **lib/grandpa:** fix grandpa stall and various bugs ([#1708](#1708)) ([67c93f4](67c93f4)) * **lib/grandpa:** fix grandpa vote message switch ([#2095](#2095)) ([461890c](461890c)) * **lib/grandpa:** fix threshold checking to be strictly greater than 2/3 ([#1891](#1891)) ([66ffe51](66ffe51)) * **lib/grandpa:** use `defaultGrandpaInterval` if not set, fixes error on startup ([#1982](#1982)) ([75627b5](75627b5)) * **lib/runtime/life:** remove import C from life ([#1923](#1923)) ([ed507d2](ed507d2)) * **lib/runtime:** update HOST_API_TEST_RUNTIME_URL to reference specific commit ([#1885](#1885)) ([666ed06](666ed06)) * **log-levels:** do not ignore configuration file log levels ([#2016](#2016)) ([80879b2](80879b2)) * pending bubble hidden after block included ([#1592](#1592)) ([5826322](5826322)) * persist node name ([#1543](#1543)) ([88b88f2](88b88f2)) * **pprof:** only run pprof service if enabled ([#2073](#2073)) ([55669c5](55669c5)) * **release:** Trigger release when pushed to main branch. ([#1566](#1566)) ([d445c97](d445c97)) * **rpc/subscription:** subscribe runtime version notify when version changes ([#1686](#1686)) ([9a76d39](9a76d39)) * Staging CI workflow ([#2034](#2034)) ([84ec792](84ec792)) * **trie:** memory leak fix in `lib/trie` ([#2009](#2009)) ([0ad5eb7](0ad5eb7)) * update deprecated package ([#1603](#1603)) ([f195204](f195204)) * update go-schnorrkel version ([#1557](#1557)) ([b86c7ff](b86c7ff)) * update gssmr genesis to use pallet_babe::SameAuthoritiesForever ([#1696](#1696)) ([fb0a751](fb0a751)) * update HOST_API_TEST_RUNTIME_URL ([#1898](#1898)) ([2ef59a8](2ef59a8)) * **utils:** create a specific folder for database ([#1598](#1598)) ([8c67795](8c67795)) ### Features * add --chain dev option ([#1561](#1561)) ([04a2969](04a2969)) * Add properties and chainId on build-spec command ([#1520](#1520)) ([b18290c](b18290c)) * cmd: implement import-runtime subcommand ([#1483](#1483)) ([d82b2da](d82b2da)) * **cmd/gossamer:** implement --telemetry-url parameter ([#1890](#1890)) ([b202e89](b202e89)), closes [#1502](#1502) * **cmd:** implement offline pruning of state trie ([#1564](#1564)) ([af9c925](af9c925)) * **devnet:** Local Gossamer Devnet ([#2008](#2008)) ([a520001](a520001)) * **dot/network, lib/grandpa:** request justification on receiving NeighbourMessage, verify justification on receipt ([#1529](#1529)) ([e1f9f42](e1f9f42)) * **dot/network:** Add cache for network message. ([#1511](#1511)) ([accaf69](accaf69)) * **dot/network:** add propagate return bool to messageHandler func type to determine whether to propagate message or not ([#1555](#1555)) ([0d6f488](0d6f488)) * **dot/network:** implement persistent peers functionality ([#1512](#1512)) ([7850532](7850532)) * **dot/network:** implement streamManager to cleanup not recently used streams ([#1611](#1611)) ([ba861bf](ba861bf)) * **dot/network:** request block justifications when near head ([#1499](#1499)) ([ae7012b](ae7012b)) * **dot/peerset:** Implement peer scoring ([#1791](#1791)) ([1c989ad](1c989ad)) * **dot/rpc/modules:** add `system_addReservedPeer` and `system_removeReservedPeer` RPC call ([#1712](#1712)) ([dba5922](dba5922)) * **dot/rpc:** Add `system_localListenAddresses` RPC call ([#1689](#1689)) ([c981d2e](c981d2e)) * **dot/rpc:** Implement `childstate_getKeys` rpc call ([#1800](#1800)) ([9b2f41e](9b2f41e)) * **dot/rpc:** implement sync_state_genSyncSpec RPC call ([#1827](#1827)) ([2186caf](2186caf)) * **dot/state:** implement online pruning of historical state tries ([#1596](#1596)) ([3eb9399](3eb9399)) * **dot/sync:** implement codeSubstitutes ([#1635](#1635)) ([d87aaeb](d87aaeb)) * dot/telemetry: Implement basic telemetry connection ([#1497](#1497)) ([fcb4159](fcb4159)) * **dot/telemetry:** Added connection retry ([#1904](#1904)) ([579a791](579a791)) * **dot/telemetry:** Added more telemetry messages in grandpa client ([#2043](#2043)) ([2e57d15](2e57d15)), closes [#1841](#1841) [#1842](#1842) * **dot/telemetry:** implement notify.finalized telemetry interface ([#1877](#1877)) ([de1a60d](de1a60d)) * **dot/telemetry:** implement substrate_number_leaves metrics ([#1926](#1926)) ([69823c0](69823c0)) * **dot/telemetry:** implement telemetry message network_state ([#1618](#1618)) ([a81844e](a81844e)) * **flags:** read log levels from flags ([#1953](#1953)) ([9694e46](9694e46)) * implement ext_default_child_storage_storage_kill_version_2 ([#1799](#1799)) ([c2908ae](c2908ae)) * implement ext_offchain_index_set_version_1 for wasmer runtime ([#1739](#1739)) ([96c30a6](96c30a6)) * **lib/babe:** add check of types.ConfigData.SecondarySlots for disabling secondary verification ([#1910](#1910)) ([cd27ae4](cd27ae4)) * **lib/grandpa:** fully verify justifications using GrandpaState ([#1544](#1544)) ([028d25e](028d25e)) * **lib/grandpa:** Include equivocatory nodes while creating justification ([#1911](#1911)) ([aca86b6](aca86b6)) * **lib/grandpa:** send NeighbourMessage to peers ([#1558](#1558)) ([322ccf9](322ccf9)) * **lib/runtime/wasmer:** implement ext_default_child_storage_storage_kill_version_3 ([#1878](#1878)) ([a719a60](a719a60)) * **lib/runtime/wasmer:** implement ext_offchain_local_storage_version_1 ([#1821](#1821)) ([0f63b17](0f63b17)) * **lib/runtime:** Implement `ext_offchain_http_request_add_header_version_1` host function ([#1994](#1994)) ([0a30b3d](0a30b3d)) * **lib/runtime:** Implement `ext_offchain_http_request_start_version_1` host function ([#1947](#1947)) ([974b1fc](974b1fc)) * **lib/runtime:** Implement `trie_blake2_256_verify_proof` host function ([#1920](#1920)) ([506565d](506565d)) * **lib/trie:** Implement `verify_proof` function ([#1883](#1883)) ([67bb5ef](67bb5ef)) * **lib/trie:** Implement limit for trie.ClearPrefix ([#1905](#1905)) ([becec9e](becec9e)) * **lib/trie:** Parallel hash trie. ([#1657](#1657)) ([22827e7](22827e7)) * **pprof:** Pprof HTTP server service ([#1991](#1991)) ([ce24ea9](ce24ea9)) * **rpc/subscription:** implement state_unsubscribeStorage ([#1574](#1574)) ([7574f10](7574f10)) * **rpc:** Implement `childstate_getChildStorage` RPC call ([#1832](#1832)) ([3d949f2](3d949f2)) * **rpc:** Implement `childstate_getStorageHash` RPC call ([#1805](#1805)) ([e539bd3](e539bd3)) * **rpc:** Implement `childstate_getStorageSize` RPC call ([#1810](#1810)) ([a04deb6](a04deb6)) * **rpc:** Implement `payment_queryInfo` RPC call ([#1826](#1826)) ([7a5deec](7a5deec)) * **rpc:** Implement `state_getReadProof` rpc call ([#1768](#1768)) ([865f80f](865f80f)) * **runtime:** implement custom logging handler that print function name ([#1825](#1825)) ([2b1276d](2b1276d)) * **telemetry:** send telemetry messages when GRANDPA receieves commit or vote messages ([#2015](#2015)) ([7bf40e1](7bf40e1)), closes [#1840](#1840) [#1839](#1839) [#1838](#1838) * **telemetry:** send txpool.import telemetry msg ([#1966](#1966)) ([ffc81bf](ffc81bf)) ### Reverts * Revert "feat(dot/rpc) implement `author_hasSessionKeys` RPC call (#1704)" (#1714) ([65380fd](65380fd)), closes [#1704](#1704) [#1714](#1714)

github-actions · 2021-12-03T21:11:05Z

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

…changes (ChainSafe#1686) * add code for runtime version changed fix * fix return type * update mock in Makefile * fix core_api mock * implement notifications for runtime updates * lint * implement unregister runtime version listener * make mocks and lint * refactor runtime subscription name, change error handeling * remove unneeded select case * lint, refactor GetID to GetChannelID * lint * add sync.WaitGroup to notify Runtime Updated * add test for Register UnRegister Runtime Update Channel * add check for id * add register panic test * add test to produce panic * generate id as uuid, add locks, delete from map * update runtime updated channel ids to use uint32 * change logging to debug * remove comment * move uuid into check loop * update runtime test * add test for notify runtime updated * update runtime tests * move runtime notify from coreAPI to blockStateAPI * fix mocks for tests * refactor state_test * add tests * lint * remove commented code, fix var assignment * fix merge conflict * add check if channel is ok * update unit test * send notification as go routine Co-authored-by: Eclésio Júnior <[email protected]>

edwardmack and others added 7 commits July 2, 2021 17:44

add code for runtime version changed fix

7325277

Merge branch 'development' into ed/fix_state_subscribeRuntimeVersion

2d324de

fix return type

9394d38

update mock in Makefile

cfe9117

fix core_api mock

37c8878

Merge branch 'development' into ed/fix_state_subscribeRuntimeVersion

fb75b48

implement notifications for runtime updates

feb5f4d

edwardmack requested review from arijitAD, EclesioMeloJunior, noot and timwu20 as code owners July 8, 2021 22:40

lint

a31474d

edwardmack added 2 commits July 9, 2021 09:37

Merge branch 'development' into ed/fix_state_subscribeRuntimeVersion

3017ed3

Merge branch 'development' into ed/fix_state_subscribeRuntimeVersion

fd83528

dutterbutter added the Status: Review Needed label Jul 9, 2021

Merge branch 'development' into ed/fix_state_subscribeRuntimeVersion

432d604

EclesioMeloJunior requested changes Jul 9, 2021

View reviewed changes

Merge branch 'development' into ed/fix_state_subscribeRuntimeVersion

0dcc08f

noot reviewed Jul 12, 2021

View reviewed changes

timwu20 reviewed Jul 12, 2021

View reviewed changes

edwardmack added 2 commits July 14, 2021 14:23

Merge branch 'development' into ed/fix_state_subscribeRuntimeVersion

d7c5d59

implement unregister runtime version listener

8c16176

EclesioMeloJunior requested changes Jul 14, 2021

View reviewed changes

edwardmack added 3 commits July 15, 2021 10:30

make mocks and lint

de0c40b

refactor runtime subscription name, change error handeling

5512348

remove unneeded select case

09c9b2e

Merge branch 'development' into ed/fix_state_subscribeRuntimeVersion

dc78e71

edwardmack requested a review from jimjbrettj as a code owner July 29, 2021 15:10

noot reviewed Jul 29, 2021

View reviewed changes

dot/state/block.go Outdated Show resolved Hide resolved

noot reviewed Jul 29, 2021

View reviewed changes

edwardmack added 8 commits August 4, 2021 17:35

Merge branch 'development' into ed/fix_state_subscribeRuntimeVersion

0de3c60

remove commented code, fix var assignment

739f8aa

Merge branch 'development' into ed/fix_state_subscribeRuntimeVersion

e3e5cef

Merge branch 'development' into ed/fix_state_subscribeRuntimeVersion

39f4a88

fix merge conflict

cb364a9

add check if channel is ok

84f89d3

Merge branch 'development' into ed/fix_state_subscribeRuntimeVersion

1a877ac

update unit test

6270ede

noot reviewed Aug 6, 2021

View reviewed changes

noot approved these changes Aug 6, 2021

View reviewed changes

timwu20 approved these changes Aug 9, 2021

View reviewed changes

edwardmack added 2 commits August 9, 2021 10:26

Merge branch 'development' into ed/fix_state_subscribeRuntimeVersion

9be6179

send notification as go routine

a22fca9

dutterbutter added Status: Approved and removed Status: Changes Requested labels Aug 12, 2021

Merge branch 'development' into ed/fix_state_subscribeRuntimeVersion

154061f

edwardmack merged commit 9a76d39 into development Aug 13, 2021

edwardmack deleted the ed/fix_state_subscribeRuntimeVersion branch August 13, 2021 20:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(rpc/subscription): subscribe runtime version notify when version changes #1686

fix(rpc/subscription): subscribe runtime version notify when version changes #1686

edwardmack commented Jul 8, 2021

codecov bot commented Jul 8, 2021 •

edited

Loading

EclesioMeloJunior Jul 9, 2021

edwardmack Jul 14, 2021

EclesioMeloJunior Jul 9, 2021

edwardmack Jul 15, 2021

noot Jul 12, 2021

edwardmack Jul 15, 2021

noot Jul 12, 2021

edwardmack Jul 15, 2021

noot left a comment

timwu20 Jul 12, 2021

edwardmack Jul 15, 2021

EclesioMeloJunior Jul 14, 2021

edwardmack Jul 15, 2021

noot Jul 29, 2021

edwardmack Aug 4, 2021

noot left a comment

noot Aug 6, 2021

edwardmack Aug 9, 2021

noot left a comment

github-actions bot commented Dec 3, 2021

fix(rpc/subscription): subscribe runtime version notify when version changes #1686

fix(rpc/subscription): subscribe runtime version notify when version changes #1686

Conversation

edwardmack commented Jul 8, 2021

Changes

Tests

Issues

codecov bot commented Jul 8, 2021 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

noot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

noot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

noot left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 3, 2021

codecov bot commented Jul 8, 2021 •

edited

Loading