Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scale.DecodeCustom and decoder.DecodeCustom should return the same types #1167

Closed
2 of 3 tasks
noot opened this issue Nov 5, 2020 · 1 comment
Closed
2 of 3 tasks

scale.DecodeCustom and decoder.DecodeCustom should return the same types #1167

noot opened this issue Nov 5, 2020 · 1 comment
Assignees
@timwu20

Comments

@noot
Copy link
Contributor

noot commented Nov 5, 2020 •
edited
Loading

Expected Behavior

currently:

func DecodeCustom(in []byte, t interface{}) error

and

func (sd *Decoder) DecodeCustom(t interface{}) (interface{}, error)

these two functions should both return error and set the decoded value to the passed in interface

Checklist

  • I have read CODE_OF_CONDUCT and CONTRIBUTING
  • I have provided as much information as possible and necessary
  • I am planning to submit a pull request to fix this issue myself
@noot noot added scale labels Nov 5, 2020
@noot
Copy link
Contributor Author

noot commented Nov 12, 2020

related to #611

@noot noot assigned noot and unassigned noot Dec 16, 2020
@dutterbutter dutterbutter added this to the Sprint 1 milestone Jan 11, 2021
@dutterbutter dutterbutter removed this from the Sprint 1 milestone Jan 21, 2021
@timwu20 timwu20 mentioned this issue Apr 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timwu20 timwu20

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timwu20 @dutterbutter @noot