CI fails to fetch patches

[mattsse]

Issue summary

• the CI fails to fetch patches due to paritytech//{substrate, polkadot, cumulus} not being valid repository names. the double slash is required in the patches, because cargo requires patch url's to be different, Patching dependencies does not work if it's for the same location but a different branch rust-lang/cargo#5478 (comment)

Other information and links

[clearloop]

Actually, we don't have to patch resources in Cargo.toml, we can just modify the commit hashes in Cargo.lock and it has the same result since we are just patching substrate like repos

The patches are horrible

[mattsse]

Yeah, that's what the patch section does, and you're not supposed to touch the lock file -.-
If we'd manage to get patches to work in the CI, it will make it so much easier to upgrade stuff, because we now have to integrate 5 repos that depend on each other, not necessarily on the same branch/state

• cumulus (requires substrate, polkadot, grandpa)
• polkadot (requires substrate, grandpa)
• substrate
• chainlink (requires substrate)

[clearloop]

-.- (QAQ)

[clearloop]

The double slash works on my machine with cargo 1.52.0-nightly

[mattsse]

Same here, my guess is that this is due:

failed to authenticate when downloading repository: ssh://[email protected]/paritytech//grandpa-bridge-gadget

mb related rust-lang/cargo#3900 rust-lang/cargo#1851
https://doc.rust-lang.org/cargo/appendix/git-authentication.html

[clearloop]

The weird thing is docker works fine

[clearloop]

Use git CLi solves

Caused by:
  failed to authenticate when downloading repository: ssh://[email protected]/paritytech//cumulus

  * attempted ssh-agent authentication, but no usernames succeeded: `git`

But new error

  fatal: remote error: 
    paritytech//polkadot is not a valid repository name
    Visit https://support.github.com/ for help

Maybe we can do a trick replacing the URI while git fetching the repos