Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Remove event bus #504

Merged
merged 7 commits into from
Sep 14, 2021
Merged

♻️ Remove event bus #504

merged 7 commits into from
Sep 14, 2021

Conversation

devenyantis
Copy link
Contributor

Description

Removing usage of event bus

Type of change

Please delete options that are not relevant.

  • Bug fix (Non-breaking change which fixes an issue)
  • New feature (Non-breaking change which adds functionality)
  • Breaking change (Fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Example: REST API changes)

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged
  • CHANGELOG.md has been updated
  • Update Gitbook REST API Page

@devenyantis devenyantis added the enhancement New feature or request label Sep 14, 2021
@devenyantis devenyantis self-assigned this Sep 14, 2021
@devenyantis devenyantis requested a review from treo September 14, 2021 01:25
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
15.1% 15.1% Duplication

@devenyantis
Copy link
Contributor Author

The unsuccessful check is caused by code duplication. Happen because I cope the chunks from verticle directly to portfoliodb

@yipkhenlai
Copy link
Contributor

Hi @devenyantis, I tested that when create project or import project, images will be loaded twice. Please check whether you meet the same issue.

Other functionalities are good. Thanks.

chrome_Qkt30idpgC

@devenyantis
Copy link
Contributor Author

Hi @devenyantis, I tested that when create project or import project, images will be loaded twice. Please check whether you meet the same issue.

Other functionalities are good. Thanks.

chrome_Qkt30idpgC

It doesn't happen on my side. Can you upload the dataset folder to google drive and send to me.

@yipkhenlai
Copy link
Contributor

yipkhenlai commented Sep 14, 2021

Hi @devenyantis, I tested that when create project or import project, images will be loaded twice. Please check whether you meet the same issue.
Other functionalities are good. Thanks.
chrome_Qkt30idpgC

It doesn't happen on my side. Can you upload the dataset folder to google drive and send to me.

Hi @devenyantis, sure

@devenyantis devenyantis merged commit e94d907 into v2_alpha_refactor Sep 14, 2021
@devenyantis devenyantis deleted the remove_eventBus branch September 14, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants