From 12cc7a5f1706bd5fa8ca1303fd5e646e20f949f4 Mon Sep 17 00:00:00 2001 From: Cheng Shao Date: Thu, 1 Jun 2023 20:11:26 +0200 Subject: [PATCH] build: set v8_enable_webassembly=false when lite mode is enabled MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We should set v8_enable_webassembly=false when lite mode is enabled, since v8_enable_lite_mode implies v8_jitless, and wasm currently doesn't work with jitless. This is automatically handled in gn, but seems to be not the case in gyp. Enabling lite mode without setting v8_enable_webassembly=false leads to "Warning: disabling flag --expose_wasm due to conflicting flags" at runtime. PR-URL: https://github.com/nodejs/node/pull/48248 Reviewed-By: Ben Noordhuis Reviewed-By: Michaël Zasso Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli --- configure.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.py b/configure.py index 83a6faead7613d..fef5b87d74da2e 100755 --- a/configure.py +++ b/configure.py @@ -1471,7 +1471,7 @@ def configure_library(lib, output, pkgname=None): def configure_v8(o): - o['variables']['v8_enable_webassembly'] = 1 + o['variables']['v8_enable_webassembly'] = 0 if options.v8_lite_mode else 1 o['variables']['v8_enable_javascript_promise_hooks'] = 1 o['variables']['v8_enable_lite_mode'] = 1 if options.v8_lite_mode else 0 o['variables']['v8_enable_gdbjit'] = 1 if options.gdb else 0