Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source install of metakernel puts its data (logo files) to /usr/metakernel #96

Closed
anntzer opened this issue May 25, 2016 · 7 comments
Closed

Comments

@anntzer
Copy link
Contributor

anntzer commented May 25, 2016

Try e.g. sudo pip install --upgrade . from the source folder. Note that the files dumped to the non-standard /usr/metakernel location don't even get removed upon sudo pip uninstall metakernel.

package_data is preferred to data_files nowadays (pypa/pip#2874 (comment)), it should be possible to install the logos within the package folder instead.

Wheels also install to the non-standard /usr/metakernel/, but at least uninstall properly from there.

@dsblank
Copy link
Member

dsblank commented May 25, 2016

We've have major issues trying to get the images to be installed and accessible here.

Can you make these changes on your setup, test to see if they work, and send a PR?

@anntzer
Copy link
Contributor Author

anntzer commented May 25, 2016

Now that' I'm going to mess up with setup.py... Would it be OK to just depend on setuptools? Also, what's the line about --single-version-externally-managed about?

svem_flag = '--single-version-externally-managed'
if svem_flag in sys.argv:
    # Die, setuptools, die.
    sys.argv.remove(svem_flag)

@blink1073
Copy link
Contributor

That was copied over from the original Bash Kernel I believe. I'd suggest modeling the setup.py and notebook extension handling after bqplot.

@anntzer
Copy link
Contributor Author

anntzer commented May 25, 2016

bqplot uses data_files to directly install some stuff into $PREFIX/share/jupyter/..., which could also be used for the kernelspec itself... perhaps not a bad idea.

@blink1073
Copy link
Contributor

That's why I recommending looking at it 😉

@dsblank
Copy link
Member

dsblank commented Jul 28, 2016

This fixed now?

@anntzer
Copy link
Contributor Author

anntzer commented Jul 28, 2016

yes

@anntzer anntzer closed this as completed Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants