Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field Properties is empty in Python and TS #40

Open
caroott opened this issue Oct 11, 2024 · 2 comments
Open

Field Properties is empty in Python and TS #40

caroott opened this issue Oct 11, 2024 · 2 comments

Comments

@caroott
Copy link
Member

caroott commented Oct 11, 2024

The field Properties of DynamicObject is unused in Python and TS and is therefore empty. The GetProperties member can be used there to retrieve key value pairs. It would possibly be a good idea to add a warning to the Field and let it fail on transpilation or make it internal only to avoid mistakes.

@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Oct 11, 2024
@HLWeil HLWeil removed the Status: Needs Triage This item is up for investigation. label Nov 20, 2024
@HLWeil HLWeil changed the title [Bug] Field Properties is empty in Python and TS Field Properties is empty in Python and TS Nov 20, 2024
@HLWeil HLWeil moved this to In discussion in ARCStack Nov 20, 2024
@kMutagene
Copy link
Member

kMutagene commented Dec 10, 2024

@HLWeil should we simply remove the member on transpilation? Otherwise, this is by-design (and confusing).

@HLWeil
Copy link
Member

HLWeil commented Dec 10, 2024

Yes, I think we should remove it from transpiled code.

To clarify for the user, remembering previous discussion, we have two approaches:

  1. set to internal
  2. Add comment to not use in Fable transpiled libraries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants