Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Optimize Sailent to increase computation speed #75

Closed
kMutagene opened this issue Oct 22, 2019 · 3 comments
Closed

[Feature Request] Optimize Sailent to increase computation speed #75

kMutagene opened this issue Oct 22, 2019 · 3 comments
Assignees
Labels
FeatureRequest project-Stats Issues regarding the BioFSharp.Stats project

Comments

@kMutagene
Copy link
Member

Is your feature request related to a problem? Please describe.
Sailent is pretty slow, as it samples bootstrap distributions millions of times depending on the iteration count. The current implementation uses an array shuffle function and takes the first n entries after creation of the shuffled array. This can be greatly improved upon.

@kMutagene kMutagene added FeatureRequest project-Stats Issues regarding the BioFSharp.Stats project labels Oct 22, 2019
@kMutagene
Copy link
Member Author

bootstrapping is now way faster with 844d2ef

@HLWeil HLWeil reopened this Feb 21, 2020
@HLWeil
Copy link
Member

HLWeil commented Feb 21, 2020

I think the computation speed of the initial data characterization step can be further optimized.

@HLWeil
Copy link
Member

HLWeil commented Feb 23, 2020

With PR #82, it's possible to work through datasets of millions of items in minutes, so I think we can close this issue again, right @kMutagene?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FeatureRequest project-Stats Issues regarding the BioFSharp.Stats project
Projects
None yet
Development

No branches or pull requests

2 participants