CGAL::CGAL_Basic_viewer enforces the definition of the preprocessor macro QT_NO_KEYWORDS

[lrineau]

That is because CGAL::CGAL_Basic_viewer enforces the definition of the preprocessor macro QT_NO_KEYWORDS.

That means you need to replace:

• slots by Q_SLOTS
• signals by QSIGNALS,
• emit by Q_EMIT, and
• foreach by Q_FOREACH.

... I wonder if that should be considered as a bug for CGAL. We should not enforce our choices to CGAL users.

Originally posted by @lrineau in #8572 (comment)

[lrineau]

I think we define QT_NO_KEYWORDS for two reasons:

• long ago, we used the name forearch, with Boost foreach, and there was a conflict, if I remember well, but that it something of the past,
• the macro emit conflicts with TBB: see profiling.h conflicts with Qt uxlfoundation/oneTBB#547

[gdamiand]

The conflict with TBB is blocking for us.

[lrineau]

The conflict with TBB is blocking for us.

I agree in CGAL Qt applications, we need to define QT_NO_KEYWORDS. But maybe not force users of CGAL::CGAL_Basic_viewer to modify their source code because we enforce QT_NO_KEYWORDS.