Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing invalid k8s YAML doesn't show the actual error #32

Open
markemeis opened this issue Dec 5, 2018 · 0 comments
Open

Importing invalid k8s YAML doesn't show the actual error #32

markemeis opened this issue Dec 5, 2018 · 0 comments
Labels
area.ui Issue in the UI area. bug Something isn't working in progress

Comments

@markemeis
Copy link
Collaborator

When importing a semantically invalid k8s YAML file, the backend produces an error which can help the user. However, that error doesn't surface to the user in the UI.

400 error from the backend with payload : {"success":false,"total":1,"data":["element3: spec.template.spec.containers[0].volumeMounts[0].mountPath: null found, string expected"]}

Expected: UI display "spec.template.spec.containers[0].volumeMounts[0].mountPath: null found, string expected" to the user

Actual: No information, user remains on the import dialog but the following is printed to the console:
VM54:1 POST http://146.148.104.79:8080/api/import 400 (Bad Request)
(anonymous) @ VM54:1
scheduleTask @ zone.js:2969
push../node_modules/zone.js/dist/zone.js.ZoneDelegate.scheduleTask @ zone.js:407
onScheduleTask @ zone.js:297
push../node_modules/zone.js/dist/zone.js.ZoneDelegate.scheduleTask @ zone.js:401
push../node_modules/zone.js/dist/zone.js.Zone.scheduleTask @ zone.js:232
push../node_modules/zone.js/dist/zone.js.Zone.scheduleMacroTask @ zone.js:255
scheduleMacroTaskWithCurrentZone @ zone.js:1114
(anonymous) @ zone.js:3001
proto.(anonymous function) @ zone.js:1394
(anonymous) @ http.js:1630
push../node_modules/rxjs/_esm5/internal/Observable.js.Observable._trySubscribe @ Observable.js:43
push../node_modules/rxjs/_esm5/internal/Observable.js.Observable.subscribe @ Observable.js:29
(anonymous) @ subscribeTo.js:21
subscribeToResult @ subscribeToResult.js:11
push../node_modules/rxjs/_esm5/internal/operators/mergeMap.js.MergeMapSubscriber._innerSub @ mergeMap.js:74
push../node_modules/rxjs/_esm5/internal/operators/mergeMap.js.MergeMapSubscriber._tryNext @ mergeMap.js:68
push../node_modules/rxjs/_esm5/internal/operators/mergeMap.js.MergeMapSubscriber._next @ mergeMap.js:51
push../node_modules/rxjs/_esm5/internal/Subscriber.js.Subscriber.next @ Subscriber.js:54
(anonymous) @ scalar.js:5
push../node_modules/rxjs/_esm5/internal/Observable.js.Observable._trySubscribe @ Observable.js:43
push../node_modules/rxjs/_esm5/internal/Observable.js.Observable.subscribe @ Observable.js:29
push../node_modules/rxjs/_esm5/internal/operators/mergeMap.js.MergeMapOperator.call @ mergeMap.js:29
push../node_modules/rxjs/_esm5/internal/Observable.js.Observable.subscribe @ Observable.js:24
push../node_modules/rxjs/_esm5/internal/operators/filter.js.FilterOperator.call @ filter.js:15
push../node_modules/rxjs/_esm5/internal/Observable.js.Observable.subscribe @ Observable.js:24
push../node_modules/rxjs/_esm5/internal/operators/map.js.MapOperator.call @ map.js:18
push../node_modules/rxjs/_esm5/internal/Observable.js.Observable.subscribe @ Observable.js:24
push../node_modules/rxjs/_esm5/internal/operators/map.js.MapOperator.call @ map.js:18
push../node_modules/rxjs/_esm5/internal/Observable.js.Observable.subscribe @ Observable.js:24
push../src/app/shared/modals/import-app-modal/import-app-modal.component.ts.ImportAppModalComponent.importApplication @ import-app-modal.component.ts:41
fileReader.onloadend @ import-app-modal.component.ts:86
push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke @ zone.js:388
onInvoke @ core.js:14143
push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke @ zone.js:387
push../node_modules/zone.js/dist/zone.js.Zone.runGuarded @ zone.js:151
(anonymous) @ zone.js:129
FileReader (async)
_global.(anonymous function).(anonymous function) @ zone.js:1345
push../src/app/shared/modals/import-app-modal/import-app-modal.component.ts.ImportAppModalComponent.readFile @ import-app-modal.component.ts:88
push../src/app/shared/modals/import-app-modal/import-app-modal.component.ts.ImportAppModalComponent.fileSelected @ import-app-modal.component.ts:75
(anonymous) @ ImportAppModalComponent.html:90
handleEvent @ core.js:19628
callWithDebugContext @ core.js:20722
debugHandleEvent @ core.js:20425
dispatchEvent @ core.js:17077
(anonymous) @ core.js:17524
(anonymous) @ platform-browser.js:993
push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invokeTask @ zone.js:421
onInvokeTask @ core.js:14134
push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invokeTask @ zone.js:420
push../node_modules/zone.js/dist/zone.js.Zone.runTask @ zone.js:188
push../node_modules/zone.js/dist/zone.js.ZoneTask.invokeTask @ zone.js:496
invokeTask @ zone.js:1540
globalZoneAwareCallback @ zone.js:1566
core.js:12584 ERROR SyntaxError: Unexpected token u in JSON at position 0
at JSON.parse ()
at SafeSubscriber._error (import-app-modal.component.ts:53)
at SafeSubscriber.push../node_modules/rxjs/_esm5/internal/Subscriber.js.SafeSubscriber.__tryOrUnsub (Subscriber.js:196)
at SafeSubscriber.push../node_modules/rxjs/_esm5/internal/Subscriber.js.SafeSubscriber.error (Subscriber.js:147)
at Subscriber.push../node_modules/rxjs/_esm5/internal/Subscriber.js.Subscriber._error (Subscriber.js:80)
at Subscriber.push../node_modules/rxjs/_esm5/internal/Subscriber.js.Subscriber.error (Subscriber.js:60)
at MapSubscriber.push../node_modules/rxjs/_esm5/internal/Subscriber.js.Subscriber._error (Subscriber.js:80)
at MapSubscriber.push../node_modules/rxjs/_esm5/internal/Subscriber.js.Subscriber.error (Subscriber.js:60)
at MapSubscriber.push../node_modules/rxjs/_esm5/internal/Subscriber.js.Subscriber._error (Subscriber.js:80)
at MapSubscriber.push../node_modules/rxjs/_esm5/internal/Subscriber.js.Subscriber.error (Subscriber.js:60)

@markemeis markemeis added bug Something isn't working area.ui Issue in the UI area. labels Dec 5, 2018
@bl8nr bl8nr self-assigned this Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area.ui Issue in the UI area. bug Something isn't working in progress
Projects
None yet
Development

No branches or pull requests

2 participants