Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImpactObject definition #2

Open
demeringo opened this issue Mar 11, 2024 · 1 comment
Open

ImpactObject definition #2

demeringo opened this issue Mar 11, 2024 · 1 comment

Comments

@demeringo
Copy link

Trying to represents impacts in a json schema leads to question: should we make all fields of an impact object mandatory ?

My understanding in the draft response.json and https://github.com/Boavizta/PCR-SI_dataformat/blob/main/ImpactObject.md is that we tend to define impacts objects as an fixed list of all (4) licecycle steps X all (18) indicators.

{
            "BLD" : {
                  "GWP": 123,
                  "ADPe": 13,
                  "ADPf": 23,
                  "WU": 12,
                  "...": ...
            },
            "DIS" : {
                  "GWP": 123,
                  "ADPe": 13,
                  "ADPf": 23,
                  "WU": 12,
                  "...": ...
             },
            "USE" : {
                  "GWP": 123,
                  "ADPe": 13,
                  "ADPf": 23,
                  "WU": 12,
                  "...": ...
            },
            "EOL" : {
                   "GWP": 123,
                  "ADPe": 13,
                  "ADPf": 23,
                  "WU": 12,
                  "...": ...
            }
}

Should we use arrays instead (maybe with explictly named properties) that would allow unknwown values to not appear ?

@Amael-PE
Copy link
Collaborator

Amael-PE commented Mar 11, 2024

We can let each of the LCA steps and indicators as optional fields, depending on the background engine.
The PCR indicators must be field for standard compliance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants