Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status bar buttons opening incorrect terminals #25

Open
Snowcola opened this issue Oct 16, 2020 · 4 comments
Open

Status bar buttons opening incorrect terminals #25

Snowcola opened this issue Oct 16, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@Snowcola
Copy link

[VS Code version: 1.50.1]
When I'm clicking on the terminal buttons in the status bar there seems to be an off by 1 error and it either opens the terminal to the right or if you click on the last terminal on the rights it wraps to the start and opens the first one.

@BenWildeman BenWildeman added the bug Something isn't working label Oct 16, 2020
@BenWildeman
Copy link
Owner

Yep, I personally see this from time to time myself

@ghost
Copy link

ghost commented Nov 17, 2020

Came here to post the same bug. Here is an observation I have seen.

If I close VS Code down with a terminal window open (from tabulous), and re-open VS Code, the same terminal window will be breifly open and then close right away. On the status bar, it will show I have a tabulous terminal open (i dont, it was closed on VS Code startup). Here I can observe the now "off by 1" error.

If I close my terminal windows down, and then close VS Code. Upon reopening, I notice that there not not a tabulous tab open, and the off by one error does not exist.

Hopefully that helps!

@rjrudin
Copy link

rjrudin commented Dec 22, 2020

Great plugin, but I'm able to consistently reproduce the same behavior from a clean start:

  1. Install the plugin
  2. Add a couple default terminals to workspace.json (example below)
  3. Run "Reload default terminals" action

The two terminals appear in the status bar correctly. But if I click on "term1", "term2" opens up, and vice versa.

Content in workspace.json file:

"tabulous.defaultTerminals": [
	{
		"name": "term1",				
	},
	{
		"name": "term2"
	}
]

@rjrudin
Copy link

rjrudin commented Dec 22, 2020

Little more info - if I have 3 terminals, then the specific problem is:

  • The first term button goes to term 2
  • The second term button goes to term 3
  • The third term button goes to term 1

Note that this only happens based on default terminals. If I then manually add new terminals, the buttons for them work correctly.

One more item - if I then manually add a new terminal, the buttons now work properly. So the problem seems to be limited to when I start VSCode and/or reload default terminals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants