[HLD] Update host service to support GCU #1007
Conversation
Signed-off-by: Gang Lv [email protected]
|
@mikelazar Could you help review? |
ganglyu
changed the title
| @@ -2,7 +2,7 @@ | |||
| Docker to Host Communications | |||
|
|
|||
| # High Level Design Document | |||
| #### Rev 0.7 | |||
| #### Rev 0.8 | |||
There was a problem hiding this comment.
Original document mentioned "translib API", is it really a dependency for applications? #Closed
There was a problem hiding this comment.
Management framework uses translib API to invoke dbus service, we can invoke dbus service directly.
| @@ -2,7 +2,7 @@ | |||
| Docker to Host Communications | |||
|
|
|||
| # High Level Design Document | |||
| #### Rev 0.7 | |||
| #### Rev 0.8 | |||
There was a problem hiding this comment.
Original document mentioned "The client application module in a container". We need to extend to client application running on the host. #Closed
| @@ -2,7 +2,7 @@ | |||
| Docker to Host Communications | |||
|
|
|||
| # High Level Design Document | |||
| #### Rev 0.7 | |||
| #### Rev 0.8 | |||
There was a problem hiding this comment.
Original document mentioned "If multiple D-Bus clients simultaneously issue requests, then each request is queued and
processed in the order received". Is it possible to the requests could be conditional processed in parallel? #Closed
There was a problem hiding this comment.
this is dbus limitation, it can't process multiple requests for the same service in parallel.
| @@ -2,7 +2,7 @@ | |||
| Docker to Host Communications | |||
|
|
|||
| # High Level Design Document | |||
| #### Rev 0.7 | |||
| #### Rev 0.8 | |||
There was a problem hiding this comment.
How does DBus host service throw an exception to the client application? #Closed
There was a problem hiding this comment.
Dbus client can get exception as error message.
| @@ -2,7 +2,7 @@ | |||
| Docker to Host Communications | |||
|
|
|||
| # High Level Design Document | |||
| #### Rev 0.7 | |||
| #### Rev 0.8 | |||
There was a problem hiding this comment.
If the client application decide to cancel a running request, how to? This is practical since gNMI service is serving a gNMI client, and the connection is broken suddenly. If continue running the request in host service may be meaningless or harmful, gNMI service may ask DBust host service to stop the request processing.
There was a problem hiding this comment.
I don't think dbus has this capability.
|
|
||
| "config apply-patch" command could take a few seconds, and D-Bus client should use timeout or asynchronous request. | ||
|
|
||
| #### 3.6.4.6 gcu.create_cp |
There was a problem hiding this comment.
cp -> checkpoint
cp is not a well-known abbreviation. #Closed
|
|
||
| # 4 Flow Diagrams | ||
|
|
||
|  | ||
|
|
||
| # 5 Error Handling | ||
| If dbus host service exited abnormally, systemd would restart this service. |
There was a problem hiding this comment.
What is the client behavior during dbus host service exited abnormally? #Closed
There was a problem hiding this comment.
client will get a dbus error message.
Signed-off-by: Gang Lv [email protected]