Modify the error message of configuring duplicate syslog to have a consistent message between versions. #2759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consistent message between versions. - What I did: Modify the error message of configuring duplicate syslog to have a consistent message between versions. - Why I did it: The error message of configuring duplicate syslog is ambiguous to user, so modify it to make it have clearer meaning. - How I verified it: Modify the code and check the error message, also build the sonic-utilities python wheel to make sure all unit test cases will pass. The error message after modification: ``` admin@sonic:~$ sudo config syslog add 20.1.1.12 Running command: systemctl reset-failed rsyslog-config rsyslog Running command: systemctl restart rsyslog-config admin@sonic:~$ admin@sonic:~$ sudo config syslog add 20.1.1.12 Usage: config syslog add [OPTIONS] SERVER_IP_ADDRESS Error: Syslog server 20.1.1.12 is already configured. <---------------- modified error message. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the error message of configuring duplicate syslog to have a consistent message between versions.
What I did
Modify the error message of configuring duplicate syslog to have a consistent message between versions.
How I did it
The error message of configuring duplicate syslog is ambiguous to user, so modify it to make it have clearer meaning.
How to verify it
Modify the code and check the error message, also build the sonic-utilities python wheel to make sure all unit test cases will pass.
The error message after modification: