-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCU] Supporting Groupings during path-xpath translation #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghooo
force-pushed
the
dev/mghoneim/groupings
branch
7 times, most recently
from
January 27, 2022 21:25
65a7dde
to
d71596c
Compare
qiluo-msft
reviewed
Jan 27, 2022
qiluo-msft
reviewed
Jan 27, 2022
qiluo-msft
reviewed
Jan 27, 2022
qiluo-msft
reviewed
Jan 27, 2022
ghooo
commented
Jan 28, 2022
wen587
previously approved these changes
Jan 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test locally and BGP_MONITOR tests works fine.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
ghooo
force-pushed
the
dev/mghoneim/groupings
branch
from
February 15, 2022 00:27
0019777
to
2bb1c02
Compare
4 tasks
ghooo
force-pushed
the
dev/mghoneim/groupings
branch
from
February 17, 2022 05:49
2bb1c02
to
21b748e
Compare
qiluo-msft
previously approved these changes
Feb 17, 2022
qiluo-msft
approved these changes
Feb 19, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixes #2041
Supporting groupings during
config-db path
<->config-yang xpath
translationThis mimics the
config-db
<->config-yang
translation as added by sonic-net/sonic-buildimage#8318How I did it
Handled groupings of leaf commands only as that's what is supported in sonic-yang-mgmt
How to verify it
unit-test
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)