Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RADIUS Management User Authentication Feature #1521

Merged
merged 3 commits into from
Apr 22, 2021
Merged

RADIUS Management User Authentication Feature #1521

merged 3 commits into from
Apr 22, 2021

Conversation

a-barboza
Copy link
Contributor

What I did

Radius Management User Authentication Feature

How I did it

HLD: https://github.com/Azure/SONiC/blob/master/doc/aaa/radius_authentication.md

How to verify it

This is the CLI only. The changes are reflected in the Redis Config DB.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

admin@sonic:~$ show radius
RADIUS global auth_type pap (default)
RADIUS global retransmit 3 (default)
RADIUS global timeout 5 (default)
RADIUS global passkey <EMPTY_STRING> (default)

admin@sonic:~$

admin@sonic:~$ sudo config radius
Usage: config radius [OPTIONS] COMMAND [ARGS]...

RADIUS server configuration

Options:
-?, -h, --help Show this message and exit.

Commands:
add Specify a RADIUS server
authtype Specify RADIUS server global auth_type [chap | pap | mschapv2]
default set its default configuration
delete Delete a RADIUS server
nasip Specify RADIUS server global NAS-IP|IPV6-Address
passkey Specify RADIUS server global passkey
retransmit Specify RADIUS server global retry attempts <0 - 10>
sourceip Specify RADIUS server global source ip
statistics Specify RADIUS server global statistics [enable | disable |...
timeout Specify RADIUS server global timeout <1 - 60>
admin@sonic:~$

HLD: https://github.com/Azure/SONiC/blob/master/doc/aaa/radius_authentication.md

CLI:

admin@sonic:~$ show radius
RADIUS global auth_type pap (default)
RADIUS global retransmit 3 (default)
RADIUS global timeout 5 (default)
RADIUS global passkey <EMPTY_STRING> (default)

admin@sonic:~$

admin@sonic:~$ sudo config radius
Usage: config radius [OPTIONS] COMMAND [ARGS]...

  RADIUS server configuration

Options:
  -?, -h, --help  Show this message and exit.

Commands:
  add         Specify a RADIUS server
  authtype    Specify RADIUS server global auth_type [chap | pap | mschapv2]
  default     set its default configuration
  delete      Delete a RADIUS server
  nasip       Specify RADIUS server global NAS-IP|IPV6-Address <IPAddress>
  passkey     Specify RADIUS server global passkey <STRING>
  retransmit  Specify RADIUS server global retry attempts <0 - 10>
  sourceip    Specify RADIUS server global source ip <IPAddress>
  statistics  Specify RADIUS server global statistics [enable | disable |...
  timeout     Specify RADIUS server global timeout <1 - 60>
admin@sonic:~$
@lguohan
Copy link
Contributor

lguohan commented Mar 24, 2021

need unit test to be added.

@lguohan lguohan requested a review from renukamanavalan March 24, 2021 01:02
@a-barboza
Copy link
Contributor Author

need unit test to be added.

Done.

@a-barboza
Copy link
Contributor Author

UT's are added and seemed to have passed.
...
[2021-03-25T22:41:02.610Z] tests/radius_test.py::TestRadius::test_show_radius_default PASSED [ 81%]
[2021-03-25T22:41:02.610Z] tests/radius_test.py::TestRadius::test_config_radius_server PASSED [ 82%]
[2021-03-25T22:41:02.610Z] tests/radius_test.py::TestRadius::test_config_radius_server_invalidkey PASSED [ 82%]
[2021-03-25T22:41:02.610Z] tests/radius_test.py::TestRadius::test_config_radius_nasip_invalid PASSED [ 82%]
[2021-03-25T22:41:02.610Z] tests/radius_test.py::TestRadius::test_config_radius_sourceip_invalid PASSED [ 82%]
[2021-03-25T22:41:02.610Z] tests/radius_test.py::TestRadius::test_config_radius_authtype PASSED [ 82%]
...
build completes
...
[2021-03-25T22:47:41.168Z] Successfully tagged docker-sonic-vs:sonic-utilities-build-pr.4574
[2021-03-25T22:47:41.168Z] + docker save docker-sonic-vs:sonic-utilities-build-pr.4574
...
sonic-swss-tests, fail in an unrelated test because of a unrelated error.
...
[2021-03-25T22:48:57.568Z] + git clone https://github.com/Azure/sonic-swss sonic-swss-tests
[2021-03-25T22:48:57.568Z] Cloning into 'sonic-swss-tests'...
...
[2021-03-26T01:31:24.475Z] ==================================== ERRORS ====================================
[2021-03-26T01:31:24.475Z] _______________ ERROR at setup of TestVxlan.test_vxlan_term_orch _______________
[2021-03-26T01:31:24.475Z]
[2021-03-26T01:31:24.475Z] self = <docker.transport.unixconn.UnixHTTPConnectionPool object at 0x7facdcc26d30>
[2021-03-26T01:31:24.475Z] conn = <docker.transport.unixconn.UnixHTTPConnection object at 0x7facdcc7abb0>
...

@yxieca
Copy link
Contributor

yxieca commented Mar 31, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@a-barboza
Copy link
Contributor Author

The system lag timing issues in the build tests are unrelated. They appear to have been fixed here (sonic-net/sonic-swss#1692)

@lguohan
Copy link
Contributor

lguohan commented Apr 14, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@renukamanavalan renukamanavalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Arun!

@renukamanavalan renukamanavalan merged commit b10c157 into sonic-net:master Apr 22, 2021
gitsabari pushed a commit to gitsabari/sonic-utilities that referenced this pull request Jun 15, 2021
What I did
Radius Management User Authentication Feature

How I did it
HLD: https://github.com/Azure/SONiC/blob/master/doc/aaa/radius_authentication.md

How to verify it
This is the CLI only. The changes are reflected in the Redis Config DB.

Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
admin@sonic:~$ show radius
RADIUS global auth_type pap (default)
RADIUS global retransmit 3 (default)
RADIUS global timeout 5 (default)
RADIUS global passkey <EMPTY_STRING> (default)

admin@sonic:~$

admin@sonic:~$ sudo config radius
Usage: config radius [OPTIONS] COMMAND [ARGS]...

RADIUS server configuration

Options:
-?, -h, --help Show this message and exit.

Commands:
add Specify a RADIUS server
authtype Specify RADIUS server global auth_type [chap | pap | mschapv2]
default set its default configuration
delete Delete a RADIUS server
nasip Specify RADIUS server global NAS-IP|IPV6-Address
passkey Specify RADIUS server global passkey
retransmit Specify RADIUS server global retry attempts <0 - 10>
sourceip Specify RADIUS server global source ip
statistics Specify RADIUS server global statistics [enable | disable |...
timeout Specify RADIUS server global timeout <1 - 60>
admin@sonic:~$
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants