Fix portconfig portchannel 201911 #1384
Conversation
* Adding support of PortChannels to portconfig script to be able to configure PortChannels by CLI commands, like 'config interface mtu' Signed-off-by: Maksym Belei <[email protected]>
* Reformat the script according to Python code style, fix typos. Signed-off-by: Maksym Belei <[email protected]>
ghost
mentioned this pull request
There was a problem hiding this comment.
Changes looks good. Can you add the unit test test cases to handle the scenarios to ensure MTU can be changed for port channels as well as error cases where the prefix of the port/portchannel is not correct and the handler fails the configuration request.
Also, I think this code has other changes already so please rebase to the latest. I will review and merge once these are done. Thanks!
What needs to be done here? I would like to this feature to be merged to the community sonic aswell. |
|
Currently I had to manually edit |
- What I did
Resolves sonic-net/sonic-buildimage#6430
Added support of PortChannels to portconfig script.
- How I did it
Added checking of prefix in name of port, passed to the script. If it is
EthernetXX, the script uses table namePORTto operate with DB, if it isPortChannelXX, then the script will use table namePORTCHANNEL, otherwise it will throw an exception to notify that port type is wrong.- How to verify it
ip link show PortChannel0001- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)
if to try to pass some trash as port argument, like this
sudo config interface mtu Unknown0002 9100, you will receive error in console output:Invalid port type specified