[crm/show]fix the 'crm show' error for acl table which bind point typ… #1178
Conversation
…e is not PORT. Signed-off-by: wangshengjun <[email protected]>
| crm_stats['crm_stats_' + res + "_used"], | ||
| crm_stats['crm_stats_' + res + "_available"] | ||
| ]) | ||
| if "crm_stats_" + res + "_used" in crm_stats: |
There was a problem hiding this comment.
Is it a bug that we only have group but not table? can you please provide the show acl table output?
There was a problem hiding this comment.
admin@sonic:~$ show acl table
Name Type Binding Description Stage
Test2 L3 PortChannel0001 test2 ingress
admin@sonic:~$ crm show resources acl table
Table ID Resource Name Used Count Available Count
0x700000000036a acl_entry 2 254
Table ID Resource Name Used Count Available Count
0x70000000003c9 acl_entry 1 255
0x70000000003c9 acl_counter 1 255
There was a problem hiding this comment.
When we create acl table, aclorch uses 'SAI_ACL_BIND_POINT_TYPE_PORT' as the fixed parameters for 'incCrmAclUsedCounter'.
There was a problem hiding this comment.
I think that is probably a bug, but I still don't understand how we trigger this bug in the CLI. I think all tables that aclorch creates have port + LAG bindings regardless of whether the members of that tables are ports or LAGs. So why does this only appear when the table members are LAGs?
There was a problem hiding this comment.
@daall, thats because in this test example, there is only one entry for LAG and nothing for port. Are you saying that is not expected?
admin@sonic:~$ show acl table
Name Type Binding Description Stage
Test2 L3 PortChannel0001 test2 ingress
There was a problem hiding this comment.
@prsunny let me try applying the orchagent fix and seeing what happens. I agree with you and @wangshengjun that orchagent should be updating the CRM for BIND_POINT_LAG as well, but I am unsure if that will totally fix this problem or if this (or some other CLI update) is still needed.
There was a problem hiding this comment.
@daall if you try to fix the aclorch, please think about the scenario that acl table bind on both port and LAG.In this case, the CRM shoud add for both port and LAG for one acl table, is that reasonable for CRM?And if we add twice for one acl table, what about the del case for that acl table, how to deal with the CRM?
There was a problem hiding this comment.
@daall Is there any progress can share with us?
There was a problem hiding this comment.
@wangshengjun I believe the orchagent changes have been fully merged now, could you let us know if you still see this bug in the latest master image? :)
|
Retest this please |
…e is not PORT.
Signed-off-by: wangshengjun [email protected]
- What I did
Fix the 'crm show' error for acl table which bind point type is LAG.
- How I did it
check whether the key exists in the dict before dump the data.
- How to verify it
admin@sonic:
$ cat acl_redirect_portchannel.json$ sudo config load acl_redirect_portchannel.json{
"ACL_TABLE":{
"Test2":{
"policy_desc":"test2",
"type":"L3",
"ports":["PortChannel0001"]
}
},
"ACL_RULE":{
"Test2|RULE1":{
"PRIORITY":"100",
"SRC_IP":"2.1.1.1",
"PACKET_ACTION":"DROP"
}
}
}
admin@sonic:
Load config from the file(s) acl_redirect_portchannel.json ? [y/N]: y
Running command: /usr/local/bin/sonic-cfggen -j acl_redirect_portchannel.json --write-to-db
admin@sonic:~$ show acl table
Name Type Binding Description Stage
Test2 L3 PortChannel0001 test2 ingress
- Previous command output (if the output of a command-line utility has changed)
admin@sonic:~$ crm show resources acl group
Traceback (most recent call last):
File "/usr/bin/crm", line 12, in
sys.exit(cli())
File "/usr/lib/python2.7/dist-packages/click/core.py", line 722, in call
return self.main(*args, **kwargs)
File "/usr/lib/python2.7/dist-packages/click/core.py", line 697, in main
rv = self.invoke(ctx)
File "/usr/lib/python2.7/dist-packages/click/core.py", line 1066, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/lib/python2.7/dist-packages/click/core.py", line 1066, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/lib/python2.7/dist-packages/click/core.py", line 1066, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/lib/python2.7/dist-packages/click/core.py", line 1066, in invoke
return process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/lib/python2.7/dist-packages/click/core.py", line 895, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/lib/python2.7/dist-packages/click/core.py", line 535, in invoke
return callback(*args, **kwargs)
File "/usr/lib/python2.7/dist-packages/click/decorators.py", line 17, in new_func
return f(get_current_context(), *args, **kwargs)
File "/usr/lib/python2.7/dist-packages/crm/main.py", line 480, in group
ctx.obj["crm"].show_acl_resources()
File "/usr/lib/python2.7/dist-packages/crm/main.py", line 109, in show_acl_resources
crm_stats['crm_stats' + res + "_used"],
KeyError: 'crm_stats_acl_table_used'
127.0.0.1:6379[2]> HGETALL "CRM:ACL_STATS:INGRESS:LAG"
127.0.0.1:6379[2]>
- New command output (if the output of a command-line utility has changed)
admin@sonic:~$ crm show resources acl group
Stage Bind Point Resource Name Used Count Available Count
INGRESS PORT acl_group 0 0
INGRESS PORT acl_table 2 0
INGRESS LAG acl_group 1 0