orchagent would crash, when portsorch failed to remove bridge port #2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Root cause:
Failed to remove bridge port becasue reference count is not 0
Solution:
1. put DEL task into m_toSync, when portsorch failed to remove bridge port
2. if port was removed from vlan but m_bridge_port_id is not SAI_NULL_OBJECT_ID,
portsorch will try to remove bridgeport again until reference count is 0
prsunny
requested changes
Nov 16, 2023
| @@ -5437,11 +5455,15 @@ bool PortsOrch::removeBridgePort(Port &port) | |||
| { | |||
| SWSS_LOG_ERROR("Failed to remove bridge port %s from default 1Q bridge, rv:%d", | |||
| port.m_alias.c_str(), status); | |||
| #if 0 | |||
There was a problem hiding this comment.
We cannot have dead code.
|
Please add unit tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Why I did it
How I verified it
Details if related