-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mlag]Fix dynamic local fdb not save to state db #1932
Open
pettershao-ragilenetworks
wants to merge
11
commits into
sonic-net:master
Choose a base branch
from
pettershao-ragilenetworks:fix_dynamic_local_fdb_not_save_to_state_db
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[mlag]Fix dynamic local fdb not save to state db #1932
pettershao-ragilenetworks
wants to merge
11
commits into
sonic-net:master
from
pettershao-ragilenetworks:fix_dynamic_local_fdb_not_save_to_state_db
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not_save_to_state_db
Signed-off-by: pettershao-ragilenetworks <[email protected]>
@prsunny @Praveen-Brcm help check and forward this, thanks! |
prsunny
reviewed
Sep 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, minor comment
@prsunny help forward this, thanks! |
Signed-off-by: pettershao-ragilenetworks <[email protected]>
Signed-off-by: pettershao-ragilenetworks <[email protected]>
Signed-off-by: pettershao-ragilenetworks <[email protected]>
Signed-off-by: pettershao-ragilenetworks <[email protected]>
check newest test case:test_mclagFdb_remote_to_local has passed. |
@qiluo-msft @lguohan help merge this, thanks! |
@gechiang help forward this, thanks! |
Praveen-Brcm
previously approved these changes
Feb 8, 2022
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix dynamic local fdb not save to state db, issue is as below:
Why I did it
If dynamic local fdb not save to state db, then clear fdb will fail to remove fdb entry in state db and iccpd will not got clear notification, fdb entry in iccpd will not sync with asic db, and peer device's fdb will not remove either.
How I verified it
clear fdb all
Details if related