Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-swss] Add port auto negotiation support to swss #1714

Merged
merged 7 commits into from
May 19, 2021

Conversation

Junchao-Mellanox
Copy link
Collaborator

What I did

  1. Added port auto negotiation attributes handle
  2. Get supported speeds for each port and save them to CONFIG_DB
  3. Added new test cases in VS test to verify the change

Why I did it

To support port auto negotiation feature.

How I verified it

Manual test and vs test

Details if related

@Junchao-Mellanox
Copy link
Collaborator Author

Depends on sonic-net/sonic-buildimage#7361

@Junchao-Mellanox
Copy link
Collaborator Author

Since sonic-net/sonic-buildimage#7361 is merged, could you please help re-triger the test?

@lguohan lguohan requested a review from jleveque April 24, 2021 20:10
orchagent/portsorch.cpp Outdated Show resolved Hide resolved
orchagent/portsorch.cpp Outdated Show resolved Hide resolved
orchagent/portsorch.cpp Outdated Show resolved Hide resolved
orchagent/portsorch.cpp Outdated Show resolved Hide resolved
orchagent/portsorch.cpp Outdated Show resolved Hide resolved
orchagent/portsorch.cpp Outdated Show resolved Hide resolved
jleveque
jleveque previously approved these changes Apr 28, 2021
@liat-grozovik
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jleveque
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Junchao-Mellanox Junchao-Mellanox requested a review from jleveque May 11, 2021 01:34
@Junchao-Mellanox
Copy link
Collaborator Author

Hi @jleveque , I have fixed the vs test issue, could you please kindly review it again?

orchagent/port.h Outdated Show resolved Hide resolved
jleveque
jleveque previously approved these changes May 11, 2021
@Junchao-Mellanox
Copy link
Collaborator Author

Fixed conflict

@jleveque jleveque merged commit 3629d70 into sonic-net:master May 19, 2021
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-swss that referenced this pull request Oct 5, 2021
1. Added port auto negotiation attributes handle
2. Get supported speeds for each port and save them to CONFIG_DB
3. Added new test cases in VS test to verify the change
@Junchao-Mellanox Junchao-Mellanox deleted the port-auto-neg-review branch October 29, 2021 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants