[snmp] Allow system with no ports in config db run without errors #221

liorghub · 2021-06-28T13:18:00Z

What I did
Allow system with no ports in config db run without errors.
This is needed for modular system which should boot properly without line cards.

How I did it
Remove snmpagent error exit if there are no ports in config DB or in counters DB.

How to verify it
Run snmpwalk on the root oid.

Important
This PR must be merged only after PR sonic-net/sonic-py-swsssdk#109 is merged.

Signed-off-by: liora <[email protected]>

lgtm-com · 2021-07-25T16:09:37Z

This pull request introduces 1 alert when merging 49188ec into 21d7d97 - view on LGTM.com

new alerts:

1 for Wrong name for an argument in a call

liorghub · 2021-07-25T17:59:47Z

Wrong name for an argument in a call

It is failing since in this commit we call function get_interface_oid_map in its new form.
The signature of function get_interface_oid_map was modified by me (hence the failure) in PR sonic-net/sonic-py-swsssdk#109.
Therefore PR sonic-net/sonic-py-swsssdk#109 should be merged before this PR.

Signed-off-by: liora <[email protected]>

liorghub · 2021-08-10T14:56:14Z

Important
This PR should be merged only after PR sonic-net/sonic-py-swsssdk#109 is merged.

liorghub · 2021-08-11T07:55:43Z

@qiluo-msft checkers are failing from the same reason I stated above.

It is failing since in this commit we call function get_interface_oid_map in its new form.
The signature of get_interface_oid_map was modified by me in PR sonic-net/sonic-py-swsssdk#109 (hence the failure).
Therefore PR sonic-net/sonic-py-swsssdk#109 must be merged before we can rerun the checkers for this PR.

qiluo-msft · 2021-08-17T04:00:36Z

tests/test_mibs.py

@@ -30,3 +35,16 @@ def test_init_sync_d_lag_tables(self):

        self.assertTrue("PortChannel_Temp" in lag_name_if_name_map)
        self.assertTrue(lag_name_if_name_map["PortChannel_Temp"] == [])
+
+    @mock.patch('swsssdk.dbconnector.SonicV2Connector.get_all', mock.MagicMock(return_value=({})))


swsssdk

swsssdk or swsscommon? #Closed

Did you run python3 -m pytest -s -v -k test_init_sync_d_interface_tables ?

swsssdk is the right one (method get_all is part of class SonicV2Connector which is implemented in sonic-buildimage/sonic-py-swsssdk/src/swsssdk/dbconnector.py).
Yes, I ran python3 -m pytest -s -v -k test_init_sync_d_interface_tables.

qiluo-msft · 2021-08-30T03:45:10Z

Could you solve the conflicts?

liorghub · 2021-08-31T12:37:24Z

Could you solve the conflicts?

@qiluo-msft
Hi Qi, there is no conflict.
In this commit, we call function get_interface_oid_map in its new form.
The signature of function get_interface_oid_map was modified by me in PR sonic-net/sonic-py-swsssdk#109.
Therefore PR sonic-net/sonic-py-swsssdk#109 must be merged before this PR.

qiluo-msft · 2021-09-01T12:31:53Z

This is the conflict github reported:

#109) **What I did** Allow system with no ports in config db to run without errors/warnings. This is needed for modular system which should boot and run properly without line cards. **How I did it** Check if table exists before calling get_all for it and return empty list if there are no ports in COUNTERS_PORT_NAME_MAP table in counters db. **How to verify it** Run snmpwalk on the root oid. **Important** This PR must be merged before PR sonic-net/sonic-snmpagent#221 is merged.

liorghub · 2021-09-05T15:07:37Z

This is the conflict github reported:

@qiluo-msft I resolved the conflict, thanks for the heads up.

liorghub · 2021-09-06T03:23:23Z

@qiluo-msft
Tests are failing due to the following issue:

if_name_map_util, if_id_map_util = port_util.get_interface_oid_map(db_conn, blocking=False)
TypeError: get_interface_oid_map() got an unexpected keyword argument 'blocking'

PR sonic-net/sonic-py-swsssdk#109 contains the required change in get_interface_oid_map() and it is merged, however tests ran with the old version of the function, do you know why?

qiluo-msft · 2021-09-07T07:27:38Z

PR Azure/sonic-py-swsssdk#109 contains the required change in get_interface_oid_map() and it is merged, however tests ran with the old version of the function, do you know why?

You need to move submodule in sonic-buildimage repo.

liorghub · 2021-09-07T17:05:31Z

PR Azure/sonic-py-swsssdk#109 contains the required change in get_interface_oid_map() and it is merged, however tests ran with the old version of the function, do you know why?

You need to move submodule in sonic-buildimage repo.

@qiluo-msft
Thanks for the clarification.
Submodule update PR - sonic-net/sonic-buildimage#8696

liat-grozovik · 2021-09-13T09:22:04Z

/azp run

azure-pipelines · 2021-09-13T09:22:09Z

Commenter does not have sufficient privileges for PR 221 in repo Azure/sonic-snmpagent

liorghub · 2021-09-13T09:38:26Z

@liat-grozovik
We should rerun checkers only after I will update the hash of sonic-py-swsssdk submodule in sonic-buildimage.
I will update the hash right after sonic-net/sonic-py-swsssdk#114 is merged.

qiluo-msft · 2021-09-13T14:42:31Z

Please update the hash of sonic-py-swsssdk submodule in sonic-buildimage.

liorghub · 2021-09-16T17:25:38Z

@qiluo-msft sonic-buildimage is updated with the latest sonic-py-swsssdk hash (see sonic-net/sonic-buildimage#8757) can you please rerun the checkers?

qiluo-msft · 2021-09-17T04:17:33Z

/azp run

azure-pipelines · 2021-09-17T04:17:41Z

Azure Pipelines successfully started running 1 pipeline(s).

qiluo-msft · 2021-09-17T04:18:02Z

PR owner could retrigger checkers by "/azpw run"

liorghub added 3 commits June 13, 2021 02:46

[snmp] Allow system with no ports in config db run without errors

cd55670

Signed-off-by: liora <[email protected]>

[snmp] Allow system with no ports in config db run without errors

aed2020

Signed-off-by: liora <[email protected]>

[snmp] Allow system with no ports in config db run without errors

f21641e

Signed-off-by: liora <[email protected]>

liorghub force-pushed the zero_ports_2 branch from 9b4b274 to f21641e Compare June 28, 2021 13:21

[snmp] Allow system with no ports in config db run without errors

49188ec

Signed-off-by: liora <[email protected]>

liorghub mentioned this pull request Jul 25, 2021

[port_util] Allow system without ports in config db run without errors sonic-net/sonic-py-swsssdk#109

Merged

[snmp] Add unitest for system without ports in config db

501b712

Signed-off-by: liora <[email protected]>

This was referenced Aug 11, 2021

SONiC Zero ports PR tracker sonic-net/sonic-buildimage#8431

Open

SONiC Zero ports PR tracker sonic-net/SONiC#835

Closed

liat-grozovik requested a review from qiluo-msft August 16, 2021 10:14

qiluo-msft reviewed Aug 17, 2021

View reviewed changes

qiluo-msft previously approved these changes Aug 17, 2021

View reviewed changes

Merge branch 'master' into zero_ports_2

3762dfb

liorghub dismissed qiluo-msft’s stale review via 3762dfb September 5, 2021 15:05

qiluo-msft approved these changes Sep 7, 2021

View reviewed changes

qiluo-msft merged commit c2d4945 into sonic-net:master Sep 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[snmp] Allow system with no ports in config db run without errors #221

[snmp] Allow system with no ports in config db run without errors #221

liorghub commented Jun 28, 2021 •

edited

Loading

lgtm-com bot commented Jul 25, 2021

liorghub commented Jul 25, 2021 •

edited

Loading

liorghub commented Aug 10, 2021

liorghub commented Aug 11, 2021 •

edited

Loading

qiluo-msft Aug 17, 2021 •

edited

Loading

qiluo-msft Aug 17, 2021

liorghub Aug 29, 2021

qiluo-msft commented Aug 30, 2021

liorghub commented Aug 31, 2021

qiluo-msft commented Sep 1, 2021

liorghub commented Sep 5, 2021

liorghub commented Sep 6, 2021

qiluo-msft commented Sep 7, 2021

liorghub commented Sep 7, 2021

liat-grozovik commented Sep 13, 2021

azure-pipelines bot commented Sep 13, 2021

liorghub commented Sep 13, 2021

qiluo-msft commented Sep 13, 2021

liorghub commented Sep 16, 2021 •

edited

Loading

qiluo-msft commented Sep 17, 2021

azure-pipelines bot commented Sep 17, 2021

qiluo-msft commented Sep 17, 2021

[snmp] Allow system with no ports in config db run without errors #221

[snmp] Allow system with no ports in config db run without errors #221

Conversation

liorghub commented Jun 28, 2021 • edited Loading

lgtm-com bot commented Jul 25, 2021

liorghub commented Jul 25, 2021 • edited Loading

liorghub commented Aug 10, 2021

liorghub commented Aug 11, 2021 • edited Loading

qiluo-msft Aug 17, 2021 • edited Loading

Choose a reason for hiding this comment

qiluo-msft Aug 17, 2021

Choose a reason for hiding this comment

liorghub Aug 29, 2021

Choose a reason for hiding this comment

qiluo-msft commented Aug 30, 2021

liorghub commented Aug 31, 2021

qiluo-msft commented Sep 1, 2021

liorghub commented Sep 5, 2021

liorghub commented Sep 6, 2021

qiluo-msft commented Sep 7, 2021

liorghub commented Sep 7, 2021

liat-grozovik commented Sep 13, 2021

azure-pipelines bot commented Sep 13, 2021

liorghub commented Sep 13, 2021

qiluo-msft commented Sep 13, 2021

liorghub commented Sep 16, 2021 • edited Loading

qiluo-msft commented Sep 17, 2021

azure-pipelines bot commented Sep 17, 2021

qiluo-msft commented Sep 17, 2021

liorghub commented Jun 28, 2021 •

edited

Loading

liorghub commented Jul 25, 2021 •

edited

Loading

liorghub commented Aug 11, 2021 •

edited

Loading

qiluo-msft Aug 17, 2021 •

edited

Loading

liorghub commented Sep 16, 2021 •

edited

Loading