Extend rfc3433.py to support more Physical Entity Sensor MIB entries #211

keboliu · 2021-04-16T13:41:07Z

- What I did

Extend RFC3433 implementation with:

FAN tachometers
PSU current sensor
PSU voltage sensor
PSU power sensor
PSU temp sensor
Chassis temp sensor

MIB HLD update PR to reflect this change please refer to: sonic-net/SONiC#766

A fix for the LGTM checker

- How I did it

Refactor sensor data parsing class by adding a base class BaseSensorData; inherit TransceiverSensorData, PSUSensorData, FANSensorData, and ThermalSensorData from it to reduce redundant code.
Adding more sensor MIB entry class: PSUTempSensor, PSUVoltageSensor, PSUCurrentSensor, PSUPowerSensor, FANSpeedSensor, and ThermalSensor.
Separate MIB update to different functions according to different sensors types: update_xcvr_dom_data, update_psu_sensor_data, update_fan_sensor_data, and update_thermal_sensor_data.
Add unit test cases to cover the new added MIB entries.
Add lgtm.yaml to fix the LGTM checker.

- How to verify it

Manual test and run updated community SNMP test case(sonic-net/sonic-mgmt#3357).

- Description for the changelog

Fan tachometers Thermal sensors PSU Voltage, Current, Power Signed-off-by: Kebo Liu <[email protected]>

Signed-off-by: Kebo Liu <[email protected]>

…tests/test_sensor.py Signed-off-by: Kebo Liu <[email protected]>

keboliu · 2021-04-27T05:39:02Z

@SuvarnaMeenakshi would you please help to review?

tests/mock_tables/state_db.json

SuvarnaMeenakshi

As comments.

src/sonic_ax_impl/mibs/ietf/rfc3433.py

tests/namespace/test_sensor.py

keboliu · 2021-05-05T13:20:42Z

@SuvarnaMeenakshi all your comments have been addressed, please check again.

src/sonic_ax_impl/mibs/ietf/rfc3433.py

keboliu · 2021-05-06T10:40:20Z

@SuvarnaMeenakshi please check my latest commit. and for the LGTM warnings, all of them are legacy code not touched in this PR.

SuvarnaMeenakshi

LGTM

keboliu · 2021-05-08T12:42:10Z

@SuvarnaMeenakshi would you please help to restart the azure pipeline? seems one of the check is blocking.

liat-grozovik · 2021-05-09T07:42:11Z

@qiluo-msft do we need additional approval?

liat-grozovik · 2021-05-09T07:42:28Z

/azp run

azure-pipelines · 2021-05-09T07:42:33Z

Commenter does not have sufficient privileges for PR 211 in repo Azure/sonic-snmpagent

liat-grozovik · 2021-05-09T07:43:42Z

@qiluo-msft can you please help to rerun azure pipeline? it is pending few days and i have no privilege to do so

qiluo-msft · 2021-05-09T22:05:04Z

/azp run

azure-pipelines · 2021-05-09T22:05:15Z

Azure Pipelines successfully started running 1 pipeline(s).

keboliu · 2021-05-11T12:10:13Z

@qiluo-msft seems that the LGTM warning is not related to the change in the PR, and not even in the files that touched this time, what's your view? and also the "snmpagent" seems never going to be finished, it just waiting there after you started 2 days ago.

qiluo-msft · 2021-05-17T23:42:31Z

I tested and fixed lgtm.yml. Please check and cherry-pick #216

Signed-off-by: Qi Luo <[email protected]>

keboliu · 2021-05-18T03:26:15Z

@SuvarnaMeenakshi @qiluo-msft Thanks for the review and fix for the LGTM checker. now everything passed after cherry-picking the LGTM checker fix, please help to proceed.

…#3357) Extend test_snmp_phy_entity to cover new add phyEntitySensor MIB entries in PR sonic-net/sonic-snmpagent#211 What is the motivation for this PR? cover new added MIB entries in physical entity sensor MIB(RFC3433) How did you do it? Extend current test cases to check the correctness of the newly added MIB entries. How did you verify/test it? Run changed test_snmp_phy_entity Signed-off-by: Kebo Liu <[email protected]>

…sonic-net#3357) Extend test_snmp_phy_entity to cover new add phyEntitySensor MIB entries in PR sonic-net/sonic-snmpagent#211 What is the motivation for this PR? cover new added MIB entries in physical entity sensor MIB(RFC3433) How did you do it? Extend current test cases to check the correctness of the newly added MIB entries. How did you verify/test it? Run changed test_snmp_phy_entity Signed-off-by: Kebo Liu <[email protected]>

keboliu added 5 commits March 28, 2021 21:15

Extend RFC3433 to support more sensors including:

6aa3dc6

Fan tachometers Thermal sensors PSU Voltage, Current, Power Signed-off-by: Kebo Liu <[email protected]>

reduce the redundant code

7b62632

Signed-off-by: Kebo Liu <[email protected]>

Merge branch 'master' into physical_entity_sensor_mib_extension

ad2e66f

import TransceiverSensorData from new sensor_data.py

01313dc

Signed-off-by: Kebo Liu <[email protected]>

Update test mock state_db.json for new added unit test

fddab17

Signed-off-by: Kebo Liu <[email protected]>

keboliu mentioned this pull request Apr 18, 2021

[SNMP] Extend snmp test to cover new added phyEntitySensor MIB change sonic-net/sonic-mgmt#3357

Merged

3 tasks

qiluo-msft requested a review from SuvarnaMeenakshi April 23, 2021 22:53

Make the function names in tests/namespace/test_sensor.py align with …

a093bbc

…tests/test_sensor.py Signed-off-by: Kebo Liu <[email protected]>

SuvarnaMeenakshi reviewed Apr 28, 2021

View reviewed changes

tests/mock_tables/state_db.json Show resolved Hide resolved

SuvarnaMeenakshi requested changes Apr 28, 2021

View reviewed changes

src/sonic_ax_impl/mibs/ietf/rfc3433.py Outdated Show resolved Hide resolved

src/sonic_ax_impl/mibs/ietf/rfc3433.py Outdated Show resolved Hide resolved

tests/namespace/test_sensor.py Show resolved Hide resolved

fix review comments

b409e1d

SuvarnaMeenakshi reviewed May 6, 2021

View reviewed changes

src/sonic_ax_impl/mibs/ietf/rfc3433.py Outdated Show resolved Hide resolved

fix review comments

8a8e789

SuvarnaMeenakshi previously approved these changes May 6, 2021

View reviewed changes

liat-grozovik requested a review from qiluo-msft May 9, 2021 07:41

keboliu mentioned this pull request May 10, 2021

[SNMP] Update extension-to-physical-entity-mib.md to add a description about the Entity sensor MIB extension sonic-net/SONiC#766

Merged

keboliu closed this May 13, 2021

keboliu reopened this May 13, 2021

qiluo-msft mentioned this pull request May 14, 2021

Physical entity sensor mib extension #216

Closed

Add lgtm.yml

3c19b14

Signed-off-by: Qi Luo <[email protected]>

keboliu dismissed SuvarnaMeenakshi’s stale review via 3c19b14 May 18, 2021 01:07

qiluo-msft approved these changes May 18, 2021

View reviewed changes

qiluo-msft merged commit fb6c940 into sonic-net:master May 18, 2021

keboliu deleted the physical_entity_sensor_mib_extension branch May 18, 2021 05:24

liorghub mentioned this pull request Aug 11, 2021

SONiC Zero ports PR tracker sonic-net/sonic-buildimage#8431

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extend rfc3433.py to support more Physical Entity Sensor MIB entries #211

Extend rfc3433.py to support more Physical Entity Sensor MIB entries #211

keboliu commented Apr 16, 2021 •

edited

Loading

keboliu commented Apr 27, 2021

SuvarnaMeenakshi left a comment

keboliu commented May 5, 2021

keboliu commented May 6, 2021 •

edited

Loading

SuvarnaMeenakshi left a comment

keboliu commented May 8, 2021 •

edited

Loading

liat-grozovik commented May 9, 2021

liat-grozovik commented May 9, 2021

azure-pipelines bot commented May 9, 2021

liat-grozovik commented May 9, 2021

qiluo-msft commented May 9, 2021

azure-pipelines bot commented May 9, 2021

keboliu commented May 11, 2021

qiluo-msft commented May 17, 2021

keboliu commented May 18, 2021

Extend rfc3433.py to support more Physical Entity Sensor MIB entries #211

Extend rfc3433.py to support more Physical Entity Sensor MIB entries #211

Conversation

keboliu commented Apr 16, 2021 • edited Loading

keboliu commented Apr 27, 2021

SuvarnaMeenakshi left a comment

Choose a reason for hiding this comment

keboliu commented May 5, 2021

keboliu commented May 6, 2021 • edited Loading

SuvarnaMeenakshi left a comment

Choose a reason for hiding this comment

keboliu commented May 8, 2021 • edited Loading

liat-grozovik commented May 9, 2021

liat-grozovik commented May 9, 2021

azure-pipelines bot commented May 9, 2021

liat-grozovik commented May 9, 2021

qiluo-msft commented May 9, 2021

azure-pipelines bot commented May 9, 2021

keboliu commented May 11, 2021

qiluo-msft commented May 17, 2021

keboliu commented May 18, 2021

keboliu commented Apr 16, 2021 •

edited

Loading

keboliu commented May 6, 2021 •

edited

Loading

keboliu commented May 8, 2021 •

edited

Loading