[vslib] Add StateBase function for MACsec #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ze Gan <[email protected]>
Pterosaur
force-pushed
the
macsec_basestate
branch
from
8c3c3d7 to
f3cbdc0
Compare
|
retest vs please |
1 similar comment
|
retest vs please |
Signed-off-by: Ze Gan <[email protected]>
Signed-off-by: Ze Gan <[email protected]>
|
retest vs please |
kcudnik
requested changes
Nov 29, 2020
Signed-off-by: Ze Gan <[email protected]>
kcudnik
requested changes
Nov 30, 2020
vslib/src/SwitchStateBaseMACsec.cpp
Outdated
|
|
||
| if (macsecAttr.m_info == nullptr) | ||
| { | ||
| // The fail log has been recordedin findHostInterfaceInfoByPort |
There was a problem hiding this comment.
i think this message should be here insted of line 383, since this functions expects info to be not null, but findHostInterfaceInfoByPort just searches for it, and whether it found or not should not be error, please move that message here and remove from findHostInterfaceInfoByPort,
|
|
||
| macsecAttr.m_sci = sciHexStr.str(); | ||
|
|
||
| if (macsecAttr.m_sci.length() < MACSEC_SCI_LENGTH) |
vslib/src/SwitchStateBaseMACsec.cpp
Outdated
|
|
||
| if (macsecAttr.m_info == nullptr) | ||
| { | ||
| // The fail log has been recordedin findHostInterfaceInfoByPort |
There was a problem hiding this comment.
also this message should be here
vslib/src/SwitchStateBaseMACsec.cpp
Outdated
|
|
||
| if (macsecAttr.m_info == nullptr) | ||
| { | ||
| // The fail log has been recordedin findHostInterfaceInfoByPort |
vslib/src/SwitchStateBaseMACsec.cpp
Outdated
| // The fail log has been recorded at loadMACsecAttr | ||
| macsecAttrs.pop_back(); | ||
| } | ||
|
|
vslib/src/SwitchStateBaseMACsec.cpp
Outdated
|
|
||
| auto ret = get_internal(SAI_OBJECT_TYPE_MACSEC_SA, serializedObjectId, attrCount, attrList); | ||
|
|
||
| if (ret != SAI_STATUS_SUCCESS) |
Signed-off-by: Ze Gan <[email protected]>
kcudnik
approved these changes
Nov 30, 2020
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
[vslib] Add StateBase function for MACsec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ze Gan [email protected]