Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic_platform/sfp_base] Add common definition for get SFP error status #194

Merged
merged 4 commits into from
Jun 16, 2021

Conversation

stephenxs
Copy link
Collaborator

Description

Add common definitions for getting SFP error status

  • Platform API definition: get_sfp_status
  • Related constant definitions

Signed-off-by: Stephen Sun [email protected]

Motivation and Context

How Has This Been Tested?

Additional Information (Optional)

sonic_platform_base/sfp_base.py Outdated Show resolved Hide resolved
Signed-off-by: Stephen Sun <[email protected]>
@jleveque
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Copy link
Collaborator Author

Looks like it failed due to an unsatisfied dependency on yang module

2021-06-14T17:16:15.4207828Z WARNING: Running pip as root will break packages and permissions. You should install packages reliably by using venv: https://pip.pypa.io/warnings/venv
2021-06-14T17:16:15.4660349Z + sudo pip3 install sonic_config_engine-1.0-py3-none-any.whl
2021-06-14T17:16:15.8202969Z Processing ./sonic_config_engine-1.0-py3-none-any.whl
2021-06-14T17:16:15.8991885Z ERROR: Could not find a version that satisfies the requirement sonic-yang-mgmt>=1.0 (from sonic-config-engine) (from versions: none)
2021-06-14T17:16:15.8992828Z ERROR: No matching distribution found for sonic-yang-mgmt>=1.0

@jleveque
Copy link
Contributor

Looks like it failed due to an unsatisfied dependency on yang module

2021-06-14T17:16:15.4207828Z WARNING: Running pip as root will break packages and permissions. You should install packages reliably by using venv: https://pip.pypa.io/warnings/venv
2021-06-14T17:16:15.4660349Z + sudo pip3 install sonic_config_engine-1.0-py3-none-any.whl
2021-06-14T17:16:15.8202969Z Processing ./sonic_config_engine-1.0-py3-none-any.whl
2021-06-14T17:16:15.8991885Z ERROR: Could not find a version that satisfies the requirement sonic-yang-mgmt>=1.0 (from sonic-config-engine) (from versions: none)
2021-06-14T17:16:15.8992828Z ERROR: No matching distribution found for sonic-yang-mgmt>=1.0

It appears this is a new dependency which broke the CI. I have opened a PR here in an attempt to fix: #198

@jleveque
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jleveque jleveque merged commit 7670b49 into sonic-net:master Jun 16, 2021
@stephenxs stephenxs deleted the generic-get-error-status branch June 16, 2021 22:15
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
…t#194)

The Python 3 version of sonic-config-engine now depends on sonic-yang-mgmt and sonic-yang-models, so we now need to install them as part of continuous integration to get the CI working again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants