[Transceiver] Porting back parser for QSFP-DD cable type and dictionaries for QSFP-DD codes to 201811 branch #123
Conversation
…QSFP-DD codes (sonic-net#101) - Add parser for QSFP-DD cable type. - Add dictionaries for QSFP-DD codes. Signed-off-by: Shlomi Bitton <[email protected]>
|
Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info? |
@zhenggen-xu , I think there is no depending on this PR for showing QSFP-DD DOM I have attached test results to in PR info already, please review it |
I guess my question is, can you give a pointer where the sfputil is using this class? and your test result is based on what SONiC version + this PR? Any other changes/PRs required? |
@zhenggen-xu , So I need this qsfpdd_dom to be a dom decoder on our device |
OK, that was the PR I was looking for, it is depending on this one. For Silverstone platform, we should raise that PR against 201811, and it should link to this one in the description due to dependency. |
@zhenggen-xu , Sure, I will do |
|
Did you make any changes other than #101? |
|
@zhenggen-xu , no change |
|
@zhenggen-xu , Can you merge this one ? |
|
@lguohan: This PR introduces a new feature to the stable 201811 branch. What are your feelings? |
|
@mudsut4ke can we close this PR? |
Implement a better check for logical_port_name_to_physical_port_list function. Currently it will only accept names that start with "Ethernet". If we try to add other ports it will crash. In the future Arista will implement other port types. For example "Recirc0". Co-authored-by: Zhi Yuan Carl Zhao <[email protected]>
[Transceiver] Add parser for QSFP-DD cable type and dictionaries for QSFP-DD codes
Picking a change from: 9e3c2da
Test result: transceiver_info_dom.log
Signed-off-by: Wirut Getbamrung [email protected]