Moving pcied service into sonic-host-services, part #2 #9285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 12, 2021 23:22
MaratGubaiev
requested review from
lguohan,
qiluo-msft and
xumia
as code owners
|
/azpw run |
|
/AzurePipelines run |
|
Pull request contains merge conflicts. |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 9285 in repo Azure/sonic-buildimage |
|
Hi all! The conflict is because the src/sonic-platform-daemons submodule references to my fork. Checking locally, clone is OK, vs and mellanox builds are OK. As far as I can see pcied works at the mellanox platform normally. Best regards, PS Sorry for "Roman B": he is my alter ego. |
sujinmkang
reviewed
Nov 19, 2021
| @@ -39,7 +39,9 @@ | |||
| url = https://github.com/Azure/sonic-platform-common | |||
| [submodule "src/sonic-platform-daemons"] | |||
| path = src/sonic-platform-daemons | |||
| url = https://github.com/Azure/sonic-platform-daemons | |||
| url = https://github.com/MaratGubaiev/sonic-platform-daemons | |||
There was a problem hiding this comment.
Please check the changes in this file. I don't think it's related.
There was a problem hiding this comment.
You need to update the submodule with Azure/sonic-platform-daemons not your repo once the changes in sonic-platform-daemon gets merged.
Signed-off-by: Marat Gubaiev <[email protected]>
…gers Signed-off-by: Marat Gubaiev <[email protected]>
Signed-off-by: Marat Gubaiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing #7282
pcied moved into sonic-host-services
NOTE The Python Wheel unit-tests disabled due to build issues.
WARNING it should be merged with coupled changes in sonic-buildimage!
See sonic-net/sonic-platform-daemons#226
NOTE sonic-platform-daemons submodule references to https://github.com/MaratGubaiev/sonic-platform-daemons/tree/move_pcied_to_host_services (that is why src/sonic-platform-daemons is conflicting: see the message at the bottom)
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)