Get asic PCI ID from CHASSIS_STATE_DB and update asic_id in CONFIG_DB #7649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ngocdo <[email protected]>
arlakshm
reviewed
Nov 15, 2021
| @@ -24,4 +24,21 @@ if [ "$VLAN" != "" ]; then | |||
| cp /usr/share/sonic/templates/ndppd.conf /etc/supervisor/conf.d/ | |||
| fi | |||
|
|
|||
| USE_PCI_ID_IN_CHASSIS_STATE_DB=/usr/share/sonic/platform/use_pci_id_chassis | |||
There was a problem hiding this comment.
The asic_id in the DEVICE_METADATA is updated here on load_minigraph
https://github.com/Azure/sonic-buildimage/blob/07de6a39c083b2cbce19cfddffd32df4cb95f923/src/sonic-config-engine/sonic-cfggen#L389-L395
Can we add the USE_PCI_ID_IN_CHASSIS_STATE_DB check here
There was a problem hiding this comment.
Are you suggesting that we move all the logic from this PR in sonic-cfggen? I think this would basically block config-setup until chassisd publishes the PCI address of all ASICs to CHASSIS_STATE_DB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asic PCI ID (PCI address) is collected by
chassisd(insidepmon- sonic-net/sonic-platform-daemons#175) and saved inCHASSIS_STATE_DB(in redis_chassis).CHASSIS_STATE_DBis accessible byswsscontainers.At
docker-init.sh(script is called afterswsscontainer is created and before anything that could run inswsslike orchagent...), we wait until asic PCI ID of the corresponding asic is populated by chassisd. We then updateasic_idinCONFIG_DBof asic's database.A system supporting dynamic asic PCI ID identification requires to have a file (empty)
use_pci_id_chassisin itsplatformdir.When
orchagentruns, it has correct asic PCI ID in its CONFIG_DB.Together with this PR:
sonic-net/sonic-platform-daemons#175
sonic-net/sonic-platform-common#185
Signed-off-by: ngocdo [email protected]