-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[202311] Fix pstore service not running #19006
Conversation
/azpw run Azure.sonic-buildimage |
/AzurePipelines run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@saiarcot895 , Can you please approve this PR ? |
@saiarcot895 , Can you please review and approve ? |
@yxieca , Can you please merge ? |
@DavidZagury @dprital can you confirm that this change is only needed for 202311? master branch has fix by default already? I think your PR comments implies this but please confirm. |
@yxieca, yes, this PR fixes a bug in Systemd version 247.3 (systemd/systemd#18540) This bug was fixed on newer versions of Systemd, Debian Bookworm already uses the version with the fix. It can be used in other branches based on Bullseye, but since master (and 202405) has the fix already it is not needed for them. |
Why I did it
The pstore service is not able to start, even if there are backtrace for kernel panics/oops in the UEFI.
This carry a risk of filling up the UEFI storage space.
This fixes the issue - #18895
Work item tracking
How I did it
Systemd on newer version has fixed this issue by adding a dependency on the kernel module to ensure we only scan for
pstate after we can actually see pstate.
Took this fix to our system.
How to verify it
Simulate a kernel crash, and make sure that when system is live again, the backtrace are located on /var/lib/systemd/pstore/ and not /sys/fs/pstore/
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)