Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update init_cfg.json.j2 to handle global scope for lldp feature #18808

Merged
merged 3 commits into from
May 30, 2024

Conversation

abdosi
Copy link
Contributor

@abdosi abdosi commented Apr 26, 2024

What I did:

Enable control of lldp has_global_scope field based on Device runtime metada.

Why I did:
More Details: sonic-net/sonic-host-services#120
Dependent on above PR merged first and submodule update of sonic-host-services

@abdosi abdosi requested a review from lguohan as a code owner April 26, 2024 02:16
@abdosi
Copy link
Contributor Author

abdosi commented Apr 26, 2024

@mlok-nokia @anamehra for viz.

@rlhui
Copy link
Contributor

rlhui commented May 1, 2024

@mlok-nokia please help review

judyjoseph
judyjoseph previously approved these changes May 16, 2024
Copy link
Contributor

@judyjoseph judyjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lguohan
Copy link
Collaborator

lguohan commented May 19, 2024

build failure @abdosi , please check.

@abdosi
Copy link
Contributor Author

abdosi commented May 23, 2024

@abdosi
Copy link
Contributor Author

abdosi commented May 29, 2024

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@abdosi
Copy link
Contributor Author

abdosi commented May 29, 2024

/azpw ms_conflict

@abdosi
Copy link
Contributor Author

abdosi commented May 30, 2024

/azpw ms_conflict

@rlhui rlhui merged commit f5b20f8 into sonic-net:master May 30, 2024
20 checks passed
arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this pull request Jul 26, 2024
…c-net#18808)

* Update init_cfg.json.j2 to handle global scope for lldp feature

* Update sonic-feature.yang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants